From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E63C8300C for ; Mon, 1 May 2023 21:26:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232688AbjEAV0H (ORCPT ); Mon, 1 May 2023 17:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232739AbjEAV0C (ORCPT ); Mon, 1 May 2023 17:26:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC91F270E for ; Mon, 1 May 2023 14:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682976310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TuHaeHAXI9GPugBSTpdzSqqdOtmVVSm+cOC6UAbi8I0=; b=YXxCXEt5yt8A5EL1D04ZkvlO8JrjbsagcN5FvUak40BCLDtefrpfeImtnSA8TJVxAsKwkf BCJueL/xh0RGpdSft4eVZApe59azeIW1mLpA+qC+f/M6sfdLSMdsKscU2nbLuJWenuaaeL 3TezQrBLGfIbl6NJ44xx7DHWVMwYt6w= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-ZIeRDLaKOpyyTB4yqpK_kg-1; Mon, 01 May 2023 17:25:09 -0400 X-MC-Unique: ZIeRDLaKOpyyTB4yqpK_kg-1 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-3921b2f9f64so1405099b6e.0 for ; Mon, 01 May 2023 14:25:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976308; x=1685568308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TuHaeHAXI9GPugBSTpdzSqqdOtmVVSm+cOC6UAbi8I0=; b=YAugyOc7L4rRO+25SXkbdBasoSwVqJhEEKbUJ5ijMO85JuYqC2vkqbTkUf/9jVbSsY loIE7isufo04k7xYsq3advPKxDrC0NbE1vHwGjd9N31tPpbW7CLo04tYkrRNuZ8aNmwP zD+BnODNg72vdhSWsEzbqhl62BVoXs005pCTzJoRDFUprHNPuFbugc7J734vEOW4hAku AhWvj2LvnD/rKks9o19iQOJ1ULyXYVEYTZh1/ZT3n+2r8ikYOZ4zLEFfJNP+vQyWVlFJ 7RUQHniTcK+x0YVuVa8Nz+j8gsQOEbjdqc5aQBWtBVwN40UO9ikHCu3gQW9lKqDrH8hu JjZg== X-Gm-Message-State: AC+VfDx+r0NbQzSLBUOQwMnFoMqgb5TDfzWGq1Lc7CvAfqWZJ4DHUYw4 +/MPfekK5Ye3wjEHdJenPMa+zXVeuPvJpOIcRNAyElGIcj//h1JL3RVdXdIPE8MukAchujoJW+z J3gpxb7fcUNDdyrYvSpFx0iUN9kMPaPk6zZaP5Xpv0u3FKyexLS12sOQt/aZ8SBqM8eGQyWHmg2 xu7ERoHiAE X-Received: by 2002:a05:6808:5a:b0:38d:f298:6cfc with SMTP id v26-20020a056808005a00b0038df2986cfcmr7224355oic.0.1682976308134; Mon, 01 May 2023 14:25:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4SbvWwmykUItBzmqFI5W2I8HfTV/ULJhJO3zEWw6FZxUduhjFzNK4MGF6+18C35B4vrbEWQA== X-Received: by 2002:a05:6808:5a:b0:38d:f298:6cfc with SMTP id v26-20020a056808005a00b0038df2986cfcmr7224342oic.0.1682976307919; Mon, 01 May 2023 14:25:07 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id q5-20020acac005000000b0038756901d1esm11911385oif.35.2023.05.01.14.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:25:07 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v4 1/4] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Date: Mon, 1 May 2023 16:24:43 -0500 Message-Id: <20230501212446.2570364-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501212446.2570364-1-ahalaney@redhat.com> References: <20230501212446.2570364-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As stated at the below link in another review, compatible is always the first property. Follow suit here to avoid copying incorrectly in the future. Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v3: * None Changes since v2: * Collect tags Changes since v1: * None arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 339fea522509..029b23198b3a 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -352,19 +352,18 @@ ðernet { max-speed = <1000>; mdio { + compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; - compatible = "snps,dwmac-mdio"; - /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; interrupt-parent = <&tlmm>; interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ device_type = "ethernet-phy"; - compatible = "ethernet-phy-ieee802.3-c22"; }; }; }; -- 2.40.0