From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D55FC77B7C for ; Tue, 2 May 2023 01:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233313AbjEBBwb (ORCPT ); Mon, 1 May 2023 21:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbjEBBw3 (ORCPT ); Mon, 1 May 2023 21:52:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 159051FE2 for ; Mon, 1 May 2023 18:52:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A852B6209C for ; Tue, 2 May 2023 01:52:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA1B8C4339B; Tue, 2 May 2023 01:52:24 +0000 (UTC) Date: Mon, 1 May 2023 21:52:20 -0400 From: Steven Rostedt To: Ricardo Neri Cc: Peter Zijlstra , Juri Lelli , Vincent Guittot , Ricardo Neri , "Ravi V. Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J. Wysocki" , Srinivas Pandruvada , Tim Chen , Valentin Schneider , Ionela Voinescu , x86@kernel.org, linux-kernel@vger.kernel.org, Shrikanth Hegde , Srikar Dronamraju , naveen.n.rao@linux.vnet.ibm.com Subject: Re: [PATCH v4 00/12] sched: Avoid unnecessary migrations within SMT domains Message-ID: <20230501215220.2591dd22@gandalf.local.home> In-Reply-To: <20230502014254.GA1219@ranerica-svr.sc.intel.com> References: <20230406203148.19182-1-ricardo.neri-calderon@linux.intel.com> <20230429153219.GC1495785@hirez.programming.kicks-ass.net> <20230502014254.GA1219@ranerica-svr.sc.intel.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 May 2023 18:42:55 -0700 Ricardo Neri wrote: > I am sorry changelogs are not sufficiently clear. I thought stating the > overall goal in the cover letter was enough. In the future, would you > prefer that I repeat the cover letter instead of referring to it? Should > individual changelogs state the overall goal? Yes. Every commit should have a change log that explains why that commit was done without having to look elsewhere. The cover letter should be the summary of what the patches do. But 5 to 10 years from now, when a git bisect comes across a commit, there's no guarantee that a cover letter will be easily found. The change log may be the only thing a developer debugging some code will have to understand what the change was for. I'm guilty of having poor change logs which I myself suffered from, as I don't remember what I meant. So I've been more adamant on adding more detail to my change logs which has saved me a few times. -- Steve