From: "Luke D. Jones" <luke@ljones.dev>
To: linux-input@vger.kernel.org
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
rydberg@bitmath.org, linux-kernel@vger.kernel.org,
"Luke D. Jones" <luke@ljones.dev>
Subject: [PATCH 2/3] HID: asus: add keycodes for 0x6a, 0x4b, and 0xc7
Date: Wed, 3 May 2023 15:47:10 +1200 [thread overview]
Message-ID: <20230503034711.253439-2-luke@ljones.dev> (raw)
In-Reply-To: <20230503034711.253439-1-luke@ljones.dev>
These two keys are found on some models with dual display.
- 0x6a is intended for controlling the secondary screen brightness.
- 0x4b is intended for toggling the arrow keys between arrows and
page up / page down.
This key is found on a slightly modified keyboard layout.
- 0xc7 is intended to cycle through keybvoard brightnesses (upwards) but
there is not suitable existing code for this behaviour. Using
`KEY_KBDILLUMTOGGLE` is different behaviour to Windows but at least
is picked up by many desktops already.
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
drivers/hid/hid-asus.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index ac93f987d822..918d0d05ca88 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -883,6 +883,7 @@ static int asus_input_mapping(struct hid_device *hdev,
case 0xb5: asus_map_key_clear(KEY_CALC); break;
case 0xc4: asus_map_key_clear(KEY_KBDILLUMUP); break;
case 0xc5: asus_map_key_clear(KEY_KBDILLUMDOWN); break;
+ case 0xc7: asus_map_key_clear(KEY_KBDILLUMTOGGLE); break;
/* ASUS touchpad toggle */
case 0x6b: asus_map_key_clear(KEY_F21); break;
@@ -911,6 +912,12 @@ static int asus_input_mapping(struct hid_device *hdev,
/* Fn+Right Aura mode next on N-Key keyboard */
case 0xb3: asus_map_key_clear(KEY_PROG3); break;
+ /* Screenpad toggle on N-Key keyboard */
+ case 0x6a: asus_map_key_clear(KEY_F13); break;
+
+ /* Arrows/Page-up/Down toggle on N-Key keyboard */
+ case 0x4b: asus_map_key_clear(KEY_F14); break;
+
default:
/* ASUS lazily declares 256 usages, ignore the rest,
* as some make the keyboard appear as a pointer device. */
--
2.40.0
next prev parent reply other threads:[~2023-05-03 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 3:47 [PATCH 1/3] HID: asus: Add support for ASUS ROG Z13 keyboard Luke D. Jones
2023-05-03 3:47 ` Luke D. Jones [this message]
2023-05-03 3:47 ` [PATCH 3/3] HID: asus: reformat the hotkey mapping block Luke D. Jones
2023-05-23 13:17 ` [PATCH 1/3] HID: asus: Add support for ASUS ROG Z13 keyboard Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503034711.253439-2-luke@ljones.dev \
--to=luke@ljones.dev \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®