From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFF4C77B78 for ; Wed, 3 May 2023 19:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbjECTII (ORCPT ); Wed, 3 May 2023 15:08:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjECTIH (ORCPT ); Wed, 3 May 2023 15:08:07 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CB1AB6 for ; Wed, 3 May 2023 12:08:06 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puHpb-0005mD-Kq; Wed, 03 May 2023 21:08:03 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1puHpZ-0005aB-UM; Wed, 03 May 2023 21:08:01 +0200 Date: Wed, 3 May 2023 21:08:01 +0200 From: Marco Felsch To: Jun Li Cc: "festevam@gmail.com" , "kernel@pengutronix.de" , Andreas Henriksson , Xu Yang , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] arm64: dts: imx8mp-evk: add dual-role usb port1 support Message-ID: <20230503190801.5glkm3n5sn5tvg7m@pengutronix.de> References: <20230323105826.2058003-1-m.felsch@pengutronix.de> <20230327084947.dcguxgyo2lfen2ms@fatal.se> <20230503184834.qln2wwvf3pgitkmp@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230503184834.qln2wwvf3pgitkmp@pengutronix.de> User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-05-03, Marco Felsch wrote: > Hi Li, Andreas, ... > > Thanks for the advice. > > > > *reuse* compatible = "gpio-sbu-mux"; can make the basic *function* work, > > but that's not the right direction, SBU has its own signal in typec connector, > > here what we need is the Super Speed signal switch, you can see iMX8MP EVK > > use 2 GPIOs control the SS for 3 states(normal orientation, reserve orientation, > > places all channels in high impedance state), but SBU will disable both channels > > at TYPEC_STATE_USB, this is not correct for USB data, so logically we cannot > > reuse SBU either. But I think this gpio-sbu-mux.c driver can be extended to > > add support super speed signal orientation. > > Thanks for the useful input :) I was dug into the usb-c hole and now I'm > back. The "gpio-sbu-mux" should fit perfectly for our use-case, we only > have to tell the driver to act as 'orientation-switch' only. All pieces > are in place so just dts work to do. I will test my new patch and send a > new version which should support super-speed to (fingers crossed). Now I see problem you mentioned, let's see if we can extent the driver. Sorry for the noise. Regards, Marco