From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA551C7EE22 for ; Thu, 4 May 2023 19:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231189AbjEDTr2 (ORCPT ); Thu, 4 May 2023 15:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbjEDTqq (ORCPT ); Thu, 4 May 2023 15:46:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71BB9AD2F; Thu, 4 May 2023 12:44:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96E9962EB8; Thu, 4 May 2023 19:44:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B97FBC433D2; Thu, 4 May 2023 19:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683229484; bh=X7FKrMlibVA+cIy6xm4u67ib08PyLcz/1lFg2G+n3PI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LHPfjddm/TmVO21yYQ9V0D7P79g3KkFDcpOz8mLzCKw38Et02Q3DS4QRVzvPPKAEY 3xV9wZ+FmuAw14Lygrl5W8jl5+HtCq48nhGcPH+DM8Hb1CWQw1oRgAKzpwehh+6GE4 gleZ76QvxBzDT9WgSshdBMQfCJVO8u80Zf2uKJxxg1j9rueU9cdmsDbYujHAZhHrQW 6FUDwN3X6/p1DvWpBAEntrMxTyqBLQTm+JmEdWND2XEgJULukI+WZ4Ejr+jyMGmtkL SoGFGSMLPeki3DActBWkNOQM0paGxh1UH0mkHpwORc46p1d+5koPHLxObvi2lzB7+2 YZQ2ATjokxFIg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dongliang Mu , Ping-Ke Shih , Kalle Valo , Sasha Levin , tony0620emma@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 10/53] wifi: rtw88: fix memory leak in rtw_usb_probe() Date: Thu, 4 May 2023 15:43:30 -0400 Message-Id: <20230504194413.3806354-10-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504194413.3806354-1-sashal@kernel.org> References: <20230504194413.3806354-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu [ Upstream commit 48181d285623198c33bb9698992502687b258efa ] drivers/net/wireless/realtek/rtw88/usb.c:876 rtw_usb_probe() warn: 'hw' from ieee80211_alloc_hw() not released on lines: 811 Fix this by modifying return to a goto statement. Signed-off-by: Dongliang Mu Reviewed-by: Ping-Ke Shih Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20230309021636.528601-1-dzm91@hust.edu.cn Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtw88/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c index 2a8336b1847a5..68e1b782d1992 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -808,7 +808,7 @@ int rtw_usb_probe(struct usb_interface *intf, const struct usb_device_id *id) ret = rtw_usb_alloc_rx_bufs(rtwusb); if (ret) - return ret; + goto err_release_hw; ret = rtw_core_init(rtwdev); if (ret) -- 2.39.2