From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6181EC7EE22 for ; Thu, 4 May 2023 20:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbjEDUGy (ORCPT ); Thu, 4 May 2023 16:06:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232704AbjEDUFB (ORCPT ); Thu, 4 May 2023 16:05:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 962C423A2A; Thu, 4 May 2023 12:52:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 702D26387C; Thu, 4 May 2023 19:51:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 875ADC4339C; Thu, 4 May 2023 19:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683229905; bh=ENDo6/89J1yGoBlmK71uujreDBJABABZbczYgDdCfyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nEAP5x7+WTc6k45p5G6sqt9GUyowRcW1BTUmDzJd4DJzmiywxkGfII0trURt+2XJK jV8gVICQWtvdn1rOQc3Dms7IkDugBssFkj5cz3P9Gd1AtgB2m2gDnEhoH+IgFNTFJB LzNUqJKt5S30+gPBSS/sDG/zSgz0igHZ/3LT57fh8UAJLY5hNTuNN4OKdTbgcKNJi1 LaU/73FSvFcrP8k8lOb8gmzkp5t47Ro7HVMkqrFseY+da/EyhZiHk9O+gFz5JzQhMx V8tYR6yvATR8Lse4o1vAm55wirl5Ph1pZC1ZNPr7YTh/mWNASrFZVn2AvdEoKWMfPy M0JlnjBCu+4cg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Chancellor , Horatiu Vultur , Paolo Abeni , Sasha Levin , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, ndesaulniers@google.com, mkl@pengutronix.de, netdev@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH AUTOSEL 4.19 04/13] net: pasemi: Fix return type of pasemi_mac_start_tx() Date: Thu, 4 May 2023 15:51:21 -0400 Message-Id: <20230504195132.3808946-4-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504195132.3808946-1-sashal@kernel.org> References: <20230504195132.3808946-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor [ Upstream commit c8384d4a51e7cb0e6587f3143f29099f202c5de1 ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. A warning in clang aims to catch these at compile time, which reveals: drivers/net/ethernet/pasemi/pasemi_mac.c:1665:21: error: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndo_start_xmit = pasemi_mac_start_tx, ^~~~~~~~~~~~~~~~~~~ 1 error generated. ->ndo_start_xmit() in 'struct net_device_ops' expects a return type of 'netdev_tx_t', not 'int'. Adjust the return type of pasemi_mac_start_tx() to match the prototype's to resolve the warning. While PowerPC does not currently implement support for kCFI, it could in the future, which means this warning becomes a fatal CFI failure at run time. Link: https://github.com/ClangBuiltLinux/linux/issues/1750 Signed-off-by: Nathan Chancellor Reviewed-by: Horatiu Vultur Link: https://lore.kernel.org/r/20230319-pasemi-incompatible-pointer-types-strict-v1-1-1b9459d8aef0@kernel.org Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/pasemi/pasemi_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c index e2c280913fbbb..8238a70161599 100644 --- a/drivers/net/ethernet/pasemi/pasemi_mac.c +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c @@ -1435,7 +1435,7 @@ static void pasemi_mac_queue_csdesc(const struct sk_buff *skb, write_dma_reg(PAS_DMA_TXCHAN_INCR(txring->chan.chno), 2); } -static int pasemi_mac_start_tx(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t pasemi_mac_start_tx(struct sk_buff *skb, struct net_device *dev) { struct pasemi_mac * const mac = netdev_priv(dev); struct pasemi_mac_txring * const txring = tx_ring(mac); -- 2.39.2