From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 543E2C7EE21 for ; Thu, 4 May 2023 20:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232739AbjEDUHC (ORCPT ); Thu, 4 May 2023 16:07:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232806AbjEDUFP (ORCPT ); Thu, 4 May 2023 16:05:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0C7111B67; Thu, 4 May 2023 12:53:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4409D6380C; Thu, 4 May 2023 19:51:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B394BC4339C; Thu, 4 May 2023 19:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683229913; bh=dIBSv6BQn5wXPVuWTTB9InkBaS9YH0P4WpoYGgcnqrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y8a5W7L/4fbZGa1hqXXQM53YuhlsxwgTIB9UjibXl8IOG9td1p87v3ID4OC/LoEWR d7THmGZKBhfcVXs3vluJIoMQfsp33NRG/t1UhT+peNV/5mu/SBORAw9dPL7vrqdCCX IliZj3o81DS+SXPCVAFVKGDGHWuwc2Mw2MjgDjSwxrKmRVO+lNUKA3Ui6iTy1MJy7f ZXQJ9rpoE1IqDCmSMeK5CagFVErK2B4EO+iRz6GF4Zz+DVuvsel4frbRTcx7zaZ01b jTe528AOg8gcOC0bInAZcUlK8IRU7kLQDIjf+XS3/IOBR237/JOMc4J9CboPXHw1VQ io/sxORppVcJg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheng Wang , "Martin K . Petersen" , Sasha Levin , sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 07/13] scsi: message: mptlan: Fix use after free bug in mptlan_remove() due to race condition Date: Thu, 4 May 2023 15:51:24 -0400 Message-Id: <20230504195132.3808946-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504195132.3808946-1-sashal@kernel.org> References: <20230504195132.3808946-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zheng Wang [ Upstream commit f486893288f3e9b171b836f43853a6426515d800 ] mptlan_probe() calls mpt_register_lan_device() which initializes the &priv->post_buckets_task workqueue. A call to mpt_lan_wake_post_buckets_task() will subsequently start the work. During driver unload in mptlan_remove() the following race may occur: CPU0 CPU1 |mpt_lan_post_receive_buckets_work() mptlan_remove() | free_netdev() | kfree(dev); | | | dev->mtu | //use Fix this by finishing the work prior to cleaning up in mptlan_remove(). [mkp: we really should remove mptlan instead of attempting to fix it] Signed-off-by: Zheng Wang Link: https://lore.kernel.org/r/20230318081635.796479-1-zyytlz.wz@163.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/message/fusion/mptlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/message/fusion/mptlan.c b/drivers/message/fusion/mptlan.c index ebc00d47abf52..624803a887d8f 100644 --- a/drivers/message/fusion/mptlan.c +++ b/drivers/message/fusion/mptlan.c @@ -1430,7 +1430,9 @@ mptlan_remove(struct pci_dev *pdev) { MPT_ADAPTER *ioc = pci_get_drvdata(pdev); struct net_device *dev = ioc->netdev; + struct mpt_lan_priv *priv = netdev_priv(dev); + cancel_delayed_work_sync(&priv->post_buckets_task); if(dev != NULL) { unregister_netdev(dev); free_netdev(dev); -- 2.39.2