From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3301EC77B75 for ; Fri, 5 May 2023 09:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231551AbjEEJ15 (ORCPT ); Fri, 5 May 2023 05:27:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231469AbjEEJ1t (ORCPT ); Fri, 5 May 2023 05:27:49 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E80BB19927; Fri, 5 May 2023 02:27:37 -0700 (PDT) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 855492CF; Fri, 5 May 2023 11:27:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1683278852; bh=l6Dk0qKAGVGoSGHz4cAKtiNPF4yQeJEI5Z3o5yq+cYE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B6c3Se50/Nru0XMugYouJQXnSCajW5VV+UMf9R6Sff9yTkOrvUCh+MGo+3G6kqwR1 /cNII49dLm/t7vXM8Qgfq2hmplLiG8SUtf3FE4OSq5M+952yQoIw2+qqCoDt53nxvw 4nfasa/QSgvzOOE02trJRLZ04HNc4khBej9OA0Zs= Date: Fri, 5 May 2023 12:27:47 +0300 From: Laurent Pinchart To: Jiapeng Chong Cc: mchehab@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] media: nxp: remove unneeded semicolon Message-ID: <20230505092747.GU4551@pendragon.ideasonboard.com> References: <20230505060617.5327-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230505060617.5327-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiapeng, Thank you for the patch. On Fri, May 05, 2023 at 02:06:17PM +0800, Jiapeng Chong wrote: > No functional modification involved. > > ./drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:226:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4868 > Signed-off-by: Jiapeng Chong I'll update the subject line to media: nxp: imx8-isi: Remove unneeded semicolon Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > index b5ffde46f31b..f7447b2f4d77 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > @@ -223,7 +223,7 @@ static int mxc_isi_crossbar_init_cfg(struct v4l2_subdev *sd, > route->sink_pad = i; > route->source_pad = i + xbar->num_sinks; > route->flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE; > - }; > + } > > routing.num_routes = xbar->num_sources; > routing.routes = routes; -- Regards, Laurent Pinchart