From: Jonathan Cameron <jic23@kernel.org>
To: Hermes Zhang <chenhuiz@axis.com>
Cc: <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
<jmaneyrol@invensense.com>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@axis.com>
Subject: Re: [PATCH v3 0/2] Add support for the ICM 20600 IMU
Date: Sat, 6 May 2023 17:37:17 +0100 [thread overview]
Message-ID: <20230506173717.11d0d311@jic23-huawei> (raw)
In-Reply-To: <20230505054853.2155326-1-chenhuiz@axis.com>
On Fri, 5 May 2023 13:48:51 +0800
Hermes Zhang <chenhuiz@axis.com> wrote:
> The Invensense ICM-20600 is a 6-axis MotionTracking device that combines a
> 3-axis gyroscope and an 3-axis accelerometer. It is very similar to the
> ICM20602 imu which is already supported by the mpu6050 driver. The main
> difference is that the ICM-20600 has a different WHOAMI value.
>
> Notes:
> v2: require specifying "invensense,icm20602" as a fallback compatible
> in the binding, as suggested
> v3: reorder "invensense,icm20602" entry before icm20608 and add
> Reviewed-by tag from Krzysztof
Looks good to me. I want to leave a little more time for Jean-Baptiste to take
a look. If it looks like I've forgotten this in 2 weeks, feel free to give me
a poke.
Thanks,
Jonathan
>
> Hermes Zhang (2):
> dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050
> iio: imu: mpu6050: Add support for the ICM 20600 IMU
>
> .../bindings/iio/imu/invensense,mpu6050.yaml | 3 +++
> drivers/iio/imu/inv_mpu6050/Kconfig | 4 ++--
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 10 ++++++++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 6 ++++++
> drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 2 ++
> drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 5 +++++
> 6 files changed, 28 insertions(+), 2 deletions(-)
>
next prev parent reply other threads:[~2023-05-06 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 5:48 Hermes Zhang
2023-05-05 5:48 ` [PATCH v3 1/2] dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050 Hermes Zhang
2023-05-09 7:44 ` Jean-Baptiste Maneyrol
2023-05-05 5:48 ` [PATCH v3 2/2] iio: imu: mpu6050: Add support for the ICM 20600 IMU Hermes Zhang
2023-05-09 8:01 ` Jean-Baptiste Maneyrol
2023-05-06 16:37 ` Jonathan Cameron [this message]
2023-05-13 17:58 ` [PATCH v3 0/2] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230506173717.11d0d311@jic23-huawei \
--to=jic23@kernel.org \
--cc=chenhuiz@axis.com \
--cc=jmaneyrol@invensense.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®