From: Juri Lelli <juri.lelli@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Qais Yousef <qyousef@layalina.io>,
Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>, Hao Luo <haoluo@google.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
cgroups@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Wei Wang <wvw@google.com>, Rick Yiu <rickyiu@google.com>,
Quentin Perret <qperret@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Juri Lelli <juri.lelli@redhat.com>
Subject: [PATCH v3 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration
Date: Mon, 8 May 2023 09:58:48 +0200 [thread overview]
Message-ID: <20230508075854.17215-1-juri.lelli@redhat.com> (raw)
Qais reported [1] that iterating over all tasks when rebuilding root
domains for finding out which ones are DEADLINE and need their bandwidth
correctly restored on such root domains can be a costly operation (10+
ms delays on suspend-resume). He proposed we skip rebuilding root
domains for certain operations, but that approach seemed arch specific
and possibly prone to errors, as paths that ultimately trigger a rebuild
might be quite convoluted (thanks Qais for spending time on this!).
This is v3 of an alternative approach (v2 at [4]) to fix the problem.
01/06 - Rename functions deadline with DEADLINE accounting (cleanup
suggested by Qais) - no functional change
02/06 - Bring back cpuset_mutex (so that we have write access to cpusets
from scheduler operations - and we also fix some problems
associated to percpu_cpuset_rwsem)
03/06 - Keep track of the number of DEADLINE tasks belonging to each cpuset
04/06 - Use this information to only perform the costly iteration if
DEADLINE tasks are actually present in the cpuset for which a
corresponding root domain is being rebuilt
05/06 - Create DL BW alloc, free & check overflow interface for bulk
bandwidth allocation/removal - no functional change
06/06 - Fix bandwidth allocation handling for cgroup operation
involving multiple tasks
With respect to the v2 posting [4]
1 - rebase on top of Linus' tree as of today (ac9a78681b92)
2 - add the 'why' to 5/6 changelog - Peter
3 - explicitly say that we need to keep cpuset_mutex a mutex for PI on
2/6 - Peter
This set is also available from
https://github.com/jlelli/linux.git deadline/rework-cpusets
Best,
Juri
1 - https://lore.kernel.org/lkml/20230206221428.2125324-1-qyousef@layalina.io/
2 - RFC https://lore.kernel.org/lkml/20230315121812.206079-1-juri.lelli@redhat.com/
3 - v1 https://lore.kernel.org/lkml/20230329125558.255239-1-juri.lelli@redhat.com/
4 - v2 https://lore.kernel.org/lkml/20230503072228.115707-1-juri.lelli@redhat.com/
Dietmar Eggemann (2):
sched/deadline: Create DL BW alloc, free & check overflow interface
cgroup/cpuset: Free DL BW in case can_attach() fails
Juri Lelli (4):
cgroup/cpuset: Rename functions dealing with DEADLINE accounting
sched/cpuset: Bring back cpuset_mutex
sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets
cgroup/cpuset: Iterate only if DEADLINE tasks are present
include/linux/cpuset.h | 12 +-
include/linux/sched.h | 4 +-
kernel/cgroup/cgroup.c | 4 +
kernel/cgroup/cpuset.c | 244 ++++++++++++++++++++++++++--------------
kernel/sched/core.c | 41 +++----
kernel/sched/deadline.c | 67 ++++++++---
kernel/sched/sched.h | 2 +-
7 files changed, 246 insertions(+), 128 deletions(-)
--
2.40.1
next reply other threads:[~2023-05-08 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 7:58 Juri Lelli [this message]
2023-05-08 7:58 ` [PATCH v3 1/6] cgroup/cpuset: Rename functions dealing with DEADLINE accounting Juri Lelli
2023-05-08 7:58 ` [PATCH v3 2/6] sched/cpuset: Bring back cpuset_mutex Juri Lelli
2023-05-08 7:58 ` [PATCH v3 3/6] sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets Juri Lelli
2023-05-08 7:58 ` [PATCH v3 4/6] cgroup/cpuset: Iterate only if DEADLINE tasks are present Juri Lelli
2023-05-08 7:58 ` [PATCH v3 5/6] sched/deadline: Create DL BW alloc, free & check overflow interface Juri Lelli
2023-05-08 7:58 ` [PATCH v3 6/6] cgroup/cpuset: Free DL BW in case can_attach() fails Juri Lelli
2023-05-08 23:24 ` [PATCH v3 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230508075854.17215-1-juri.lelli@redhat.com \
--to=juri.lelli@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=claudio@evidence.eu.com \
--cc=dietmar.eggemann@arm.com \
--cc=gor@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=haoluo@google.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=qyousef@layalina.io \
--cc=rickyiu@google.com \
--cc=rostedt@goodmis.org \
--cc=sudeep.holla@arm.com \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®