mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
	linux-arch@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [RFC PATCH 0/3] Prohibit irq disable when disabled or enable when enabled
Date: Tue,  9 May 2023 21:07:36 +1000	[thread overview]
Message-ID: <20230509110739.241735-1-npiggin@gmail.com> (raw)

Hi,

Any thoughts on tightening this up and adding some warnings for this?
Motivated by a bug I added to powerpc which broke disabled-disable
callers.

Not that I necessarily want archs to be able to depend on this, it
would always be better to be tolerant. But it seems a risky pattern
for random code to be using.

This still fires off quite a few warnings on powerpc, and I haven't
test booted any other arch so probably wouldn't ask to upstream patch
3 just yet, but if there are no objections to the idea I might do a
bit more work on it.

Thanks,
Nick

Nicholas Piggin (3):
  hrtimer: balance irq save/restore
  init: Require archs call start_kernel with arch irqs disabled
  irqflags: Warn on irq disable when disabled and enable when enabled

 include/linux/irqflags.h       | 26 ++++++++++++++++++++++++--
 init/main.c                    |  6 +++++-
 kernel/locking/irqflag-debug.c | 14 ++++++++++++++
 kernel/time/hrtimer.c          | 22 +++++++++++-----------
 4 files changed, 54 insertions(+), 14 deletions(-)

-- 
2.40.1


             reply	other threads:[~2023-05-09 11:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 11:07 Nicholas Piggin [this message]
2023-05-09 11:07 ` [RFC PATCH 1/3] hrtimer: balance irq save/restore Nicholas Piggin
2023-05-09 11:07 ` [RFC PATCH 2/3] init: Require archs call start_kernel with arch irqs disabled Nicholas Piggin
2023-05-09 11:07 ` [RFC PATCH 3/3] irqflags: Warn on irq disable when disabled and enable when enabled Nicholas Piggin
2023-05-22  8:25   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509110739.241735-1-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®