From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Ammar Faizi" <ammarfaizi2@gnuweeb.org>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Michael William Jonathan" <moe@gnuweeb.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"io-uring Mailing List" <io-uring@vger.kernel.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: [PATCH liburing v1 0/2] 2 fixes for recv-msgall.c
Date: Wed, 10 May 2023 21:39:25 +0700 [thread overview]
Message-ID: <20230510143927.123170-1-ammarfaizi2@gnuweeb.org> (raw)
Hi Jens,
This is the follow up patchset for the recent issue found in
recv-msgall.c. There are two patches in this series.
1. Fix undefined behavior in `recv_prep()`.
The lifetime of `struct msghdr msg;` must be long enough until the CQE
is generated because the recvmsg operation will write to that storage. I
found this test segfault when compiling with -O0 optimization. This is
undefined behavior and may behave randomly. Fix this by making the
lifetime of `struct msghdr msg;` long enough.
2. Fix invalid mutex usage.
Calling pthread_mutex_lock() twice with the same mutex in the same
thread without unlocking it first is invalid. The intention behind this
pattern was to wait for the recv_fn() thread to be ready. Use the
pthread barrier instead. It is more straightforward and correct.
Please apply!
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
Ammar Faizi (2):
recv-msgall: Fix undefined behavior in `recv_prep()`
recv-msgall: Fix invalid mutex usage
test/recv-msgall.c | 44 +++++++++++++++++++++-----------------------
1 file changed, 21 insertions(+), 23 deletions(-)
base-commit: 4961ac480052089a94978e9f771d513551aff61b
--
Ammar Faizi
next reply other threads:[~2023-05-10 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 14:39 Ammar Faizi [this message]
2023-05-10 14:39 ` [PATCH liburing v1 1/2] recv-msgall: Fix undefined behavior in `recv_prep()` Ammar Faizi
2023-05-10 14:39 ` [PATCH liburing v1 2/2] recv-msgall: Fix invalid mutex usage Ammar Faizi
2023-05-10 15:17 ` [PATCH liburing v1 0/2] 2 fixes for recv-msgall.c Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510143927.123170-1-ammarfaizi2@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=axboe@kernel.dk \
--cc=gwml@vger.gnuweeb.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moe@gnuweeb.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®