From: zhenwei pi <pizhenwei@bytedance.com>
To: stefanha@redhat.com, mst@redhat.com, jasowang@redhat.com
Cc: xuanzhuo@linux.alibaba.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
zhenwei pi <pizhenwei@bytedance.com>
Subject: [PATCH 0/2] virtio: abstract virtqueue related methods
Date: Fri, 12 May 2023 17:46:16 +0800 [thread overview]
Message-ID: <20230512094618.433707-1-pizhenwei@bytedance.com> (raw)
Hi,
3 weeks ago, I posted a proposal 'Virtio Over Fabrics':
https://lists.oasis-open.org/archives/virtio-comment/202304/msg00442.html
Jason and Stefan pointed out that a non-vring based virtqueue has a
chance to overwrite virtqueue instead of using vring virtqueue.
Then I try to abstract virtqueue related methods in this series, the
details changes see the comment of patch 'virtio: abstract virtqueue related methods'.
Something is still remained:
- __virtqueue_break/__virtqueue_unbreak is supposed to use by internal
virtio core, I'd like to rename them to vring_virtqueue_break
/vring_virtqueue_unbreak. Is this reasonable?
- virtqueue_get_desc_addr/virtqueue_get_avail_addr/virtqueue_get_used_addr
/virtqueue_get_vring is vring specific, I'd like to rename them like
vring_virtqueue_get_desc_addr. Is this reasonable?
- there are still some functions in virtio_ring.c with prefix *virtqueue*,
for example 'virtqueue_add_split', just keep it or rename it to
'vring_virtqueue_add_split'?
zhenwei pi (2):
virtio: abstract virtqueue related methods
tools/virtio: implement virtqueue in test
drivers/virtio/virtio.c | 362 ++++++++++++++++++++++++++++++++++
drivers/virtio/virtio_ring.c | 282 +++++----------------------
include/linux/virtio.h | 29 +++
tools/virtio/Makefile | 4 +-
tools/virtio/linux/virtio.h | 30 +++
tools/virtio/virtqueue.c | 367 +++++++++++++++++++++++++++++++++++
6 files changed, 842 insertions(+), 232 deletions(-)
create mode 100644 tools/virtio/virtqueue.c
--
2.20.1
next reply other threads:[~2023-05-12 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 9:46 zhenwei pi [this message]
2023-05-12 9:46 ` [PATCH 1/2] " zhenwei pi
2023-05-12 10:46 ` Michael S. Tsirkin
2023-05-12 11:09 ` zhenwei pi
2023-05-12 11:35 ` Michael S. Tsirkin
2023-05-12 11:53 ` zhenwei pi
2023-05-12 16:40 ` kernel test robot
2023-05-13 17:22 ` kernel test robot
2023-05-12 9:46 ` [PATCH 2/2] tools/virtio: implement virtqueue in test zhenwei pi
2023-05-12 10:47 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512094618.433707-1-pizhenwei@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®