From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB78BC77B7C for ; Fri, 12 May 2023 13:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241302AbjELNpS (ORCPT ); Fri, 12 May 2023 09:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241250AbjELNpQ (ORCPT ); Fri, 12 May 2023 09:45:16 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBDFB132AB; Fri, 12 May 2023 06:45:15 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6671C68AA6; Fri, 12 May 2023 15:45:11 +0200 (CEST) Date: Fri, 12 May 2023 15:45:11 +0200 From: "hch@lst.de" To: Jinyoung CHOI Cc: "axboe@kernel.dk" , "kbusch@kernel.org" , "hch@lst.de" , "sagi@grimberg.me" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "johannes.thumshirn@wdc.com" , "kch@nvidia.com" , "willy@infradead.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 03/14] block: bio-integrity: cleanup bio_integrity_prep Message-ID: <20230512134511.GB32242@lst.de> References: <20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p1> <20230510085018epcms2p5a3830e37b13e9a6799298050abdc77dc@epcms2p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510085018epcms2p5a3830e37b13e9a6799298050abdc77dc@epcms2p5> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find these "block: bio-integrity:" very unreadable. It seems like a lot of commits just use block, which looks neater to me. The same also applies to many of the other patches. The patch itself looks good to me: Reviewed-by: Christoph Hellwig