From: Joy Chakraborty <joychakr@google.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, manugautam@google.com,
danielmentz@google.com, sjadavani@google.com,
Joy Chakraborty <joychakr@google.com>
Subject: [PATCH v2 4/6] dmaengine: pl330: Change unused arg "len" from get_burst_len()
Date: Fri, 12 May 2023 14:14:43 +0000 [thread overview]
Message-ID: <20230512141445.2026660-5-joychakr@google.com> (raw)
In-Reply-To: <20230512141445.2026660-1-joychakr@google.com>
Remove unused length argument from get_burst_len() and add burst size as
an argument to allow usage of this function in other places as source and
destination burst sizes are handled separately.
Signed-off-by: Joy Chakraborty <joychakr@google.com>
---
drivers/dma/pl330.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 746da0bbea92..e5e610c91f18 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2660,8 +2660,7 @@ __pl330_prep_dma_memcpy(struct dma_pl330_chan *pch, dma_addr_t dst,
return desc;
}
-/* Call after fixing burst size */
-static inline int get_burst_len(struct dma_pl330_desc *desc, size_t len)
+static inline int get_burst_len(struct dma_pl330_desc *desc, unsigned int brst_size)
{
struct dma_pl330_chan *pch = desc->pchan;
struct pl330_dmac *pl330 = pch->dmac;
@@ -2669,7 +2668,7 @@ static inline int get_burst_len(struct dma_pl330_desc *desc, size_t len)
burst_len = pl330->pcfg.data_bus_width / 8;
burst_len *= pl330->pcfg.data_buf_dep / pl330->pcfg.num_chan;
- burst_len >>= desc->rqcfg.src_brst_size;
+ burst_len >>= brst_size;
/* src/dst_burst_len can't be more than 16 */
if (burst_len > PL330_MAX_BURST)
@@ -2805,7 +2804,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
burst /= 2;
desc->rqcfg.src_brst_size = __ffs(burst);
- desc->rqcfg.src_brst_len = get_burst_len(desc, len);
+ desc->rqcfg.src_brst_len = get_burst_len(desc, desc->rqcfg.src_brst_size);
/*
* If burst size is smaller than bus width then make sure we only
* transfer one at a time to avoid a burst stradling an MFIFO entry.
--
2.40.1.606.ga4b1b128d6-goog
next prev parent reply other threads:[~2023-05-12 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 14:14 [PATCH v2 0/6] dmaengine: pl330: Updates and logical changes for peripheral usecases Joy Chakraborty
2023-05-12 14:14 ` [PATCH v2 1/6] dmaengine: pl330: Separate SRC and DST burst size and len Joy Chakraborty
2023-05-12 14:14 ` [PATCH v2 2/6] dmaengine: pl330: Use FFS to calculate burst size Joy Chakraborty
2023-05-12 14:14 ` [PATCH v2 3/6] dmaengine: pl330: Change if-else to switch-case for consistency Joy Chakraborty
2023-05-12 14:14 ` Joy Chakraborty [this message]
2023-05-12 14:14 ` [PATCH v2 5/6] dmaengine: pl330: Optimize AxSize for peripheral usecases Joy Chakraborty
2023-05-12 14:14 ` [PATCH v2 6/6] dmaengine: pl330: Use dma singles for peripheral _dregs Joy Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512141445.2026660-5-joychakr@google.com \
--to=joychakr@google.com \
--cc=danielmentz@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manugautam@google.com \
--cc=sjadavani@google.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®