From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A109C77B7A for ; Sat, 13 May 2023 17:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbjEMRmZ (ORCPT ); Sat, 13 May 2023 13:42:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230501AbjEMRmX (ORCPT ); Sat, 13 May 2023 13:42:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 420873AA6; Sat, 13 May 2023 10:42:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B54A61AEF; Sat, 13 May 2023 17:42:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 730D2C4339B; Sat, 13 May 2023 17:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683999740; bh=vPMj4FfP13zlbkAXu5vpdoPMQmngxxSeOtKc5LvkeJk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iYUseF0hp0THzJcesAPKMkWTtkOXSJ4lALPUXUOA//9x64iibya/y3IcesOvSIEsy AHEASoGPxMuSXXAer2Dx3u5gjLPXvIrM4xIFGLhvseGaqnkmqQjqWrdNAEhCSxVkwj aQ08yEs/Zu+pfZSEKJh9xyO+nUgt2XFw1Dqj9wwWbMIVSeQoUPlFa75KP0CUQ8NrPz jkZtup7nuZ85lTS1DONdBJB3NcII8Ixb+JQxO7b9rlBrXXO442fNtmLvZ7nwYMEOs5 k7ajGXloNl8VjpYYF3+QVciFsuLX7O5cEr0YdmYUPzGwkq8XqA7vz/71GGT7kpTvTi pGXSvjJ3gqqKA== Date: Sat, 13 May 2023 18:58:21 +0100 From: Jonathan Cameron To: Hermes Zhang Cc: , , , , , Subject: Re: [PATCH v3 0/2] Add support for the ICM 20600 IMU Message-ID: <20230513185821.122ac3a4@jic23-huawei> In-Reply-To: <20230506173717.11d0d311@jic23-huawei> References: <20230505054853.2155326-1-chenhuiz@axis.com> <20230506173717.11d0d311@jic23-huawei> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 May 2023 17:37:17 +0100 Jonathan Cameron wrote: > On Fri, 5 May 2023 13:48:51 +0800 > Hermes Zhang wrote: > > > The Invensense ICM-20600 is a 6-axis MotionTracking device that combines a > > 3-axis gyroscope and an 3-axis accelerometer. It is very similar to the > > ICM20602 imu which is already supported by the mpu6050 driver. The main > > difference is that the ICM-20600 has a different WHOAMI value. > > > > Notes: > > v2: require specifying "invensense,icm20602" as a fallback compatible > > in the binding, as suggested > > v3: reorder "invensense,icm20602" entry before icm20608 and add > > Reviewed-by tag from Krzysztof > > Looks good to me. I want to leave a little more time for Jean-Baptiste to take > a look. If it looks like I've forgotten this in 2 weeks, feel free to give me > a poke. Series applied to the togreg branch of iio.git and initially pushed out as testing for 0-day to take a look and see if we missed anything. Thanks, Jonathan > > Thanks, > > Jonathan > > > > > > Hermes Zhang (2): > > dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050 > > iio: imu: mpu6050: Add support for the ICM 20600 IMU > > > > .../bindings/iio/imu/invensense,mpu6050.yaml | 3 +++ > > drivers/iio/imu/inv_mpu6050/Kconfig | 4 ++-- > > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 10 ++++++++++ > > drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 6 ++++++ > > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 2 ++ > > drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 5 +++++ > > 6 files changed, 28 insertions(+), 2 deletions(-) > > >