From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02332C7EE25 for ; Sun, 14 May 2023 22:47:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234792AbjENWrs (ORCPT ); Sun, 14 May 2023 18:47:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjENWrq (ORCPT ); Sun, 14 May 2023 18:47:46 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 875E710FF; Sun, 14 May 2023 15:47:39 -0700 (PDT) Received: from mercury (unknown [185.209.196.239]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0D7B4660574D; Sun, 14 May 2023 23:47:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1684104458; bh=m7FaWHC0hcEZ+opoVXS6xLiU5AcgWk6c8qi7kt4a7f4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AMNy42BMf16qchg5vkGDSoBcfNmj+52iI/k6VlbbwocZPlbYU5ahcu3kloZZMfngv d+Lp7wZVRl551b5bcB+ez69FIj76ibqTuNK7LRJOS6RAb39+LnFLhwr4TVUi09O/PU vXSCOZcfkDDyop5GU+UUpz/AtsCna0BmqiYJjwBkSHp0/Cx9wvyMXg53vyUZDkQ7bU iipqopFvPbWB+hBldMB4kCR3A5u5zMV9RUpRLjmyqnyc1hHVavtAu3MFf2kQIP9stz whQ8EFQb4MaOrjgTMQ0wbDUCJcQzMfDPDTcMnggob5KLcLtnNXTkpUpeLU35ljfk83 0KoPVy0D8o00A== Received: by mercury (Postfix, from userid 1000) id 0D5281061381; Mon, 15 May 2023 00:47:36 +0200 (CEST) Date: Mon, 15 May 2023 00:47:36 +0200 From: Sebastian Reichel To: Jakob Hauser Cc: Lee Jones , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Beomho Seo , Chanwoo Choi , Stephan Gerhold , Raymond Hackley , Pavel Machek , Axel Lin , ChiYuan Huang , Linus Walleij , Henrik Grimler , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v5 07/10] power: supply: rt5033_battery: Move struct rt5033_battery to battery driver Message-ID: <20230514224736.guld3npymqbr3no4@mercury.elektranox.org> References: <20230514123130.41172-1-jahau@rocketmail.com> <20230514123130.41172-8-jahau@rocketmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="w66avb2qq2hrapvz" Content-Disposition: inline In-Reply-To: <20230514123130.41172-8-jahau@rocketmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --w66avb2qq2hrapvz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, May 14, 2023 at 02:31:27PM +0200, Jakob Hauser wrote: > Move struct rt5033_battery from the mfd header into the battery driver be= cause > it's not used by others. >=20 > Within struct rt5033_battery, remove the line "struct rt5033_dev *rt5033;" > because it doesn't get used. >=20 > In rt5033.h, remove #include , it's not necessary > anymore. >=20 > In rt5033_battery.c, remove #include , it's not neces= sary > anymore either. Instead add #include and >=20 > Signed-off-by: Jakob Hauser > --- Acked-by: Sebastian Reichel -- Sebastian > drivers/power/supply/rt5033_battery.c | 9 ++++++++- > include/linux/mfd/rt5033.h | 8 -------- > 2 files changed, 8 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply= /rt5033_battery.c > index 5c04cf305219..91e1efd81f69 100644 > --- a/drivers/power/supply/rt5033_battery.c > +++ b/drivers/power/supply/rt5033_battery.c > @@ -6,11 +6,18 @@ > * Author: Beomho Seo > */ > =20 > +#include > #include > #include > #include > +#include > #include > -#include > + > +struct rt5033_battery { > + struct i2c_client *client; > + struct regmap *regmap; > + struct power_supply *psy; > +}; > =20 > static int rt5033_battery_get_capacity(struct i2c_client *client) > { > diff --git a/include/linux/mfd/rt5033.h b/include/linux/mfd/rt5033.h > index 3992fb2ef0a8..bb3d18945d21 100644 > --- a/include/linux/mfd/rt5033.h > +++ b/include/linux/mfd/rt5033.h > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > =20 > /* RT5033 regulator IDs */ > enum rt5033_regulators { > @@ -32,11 +31,4 @@ struct rt5033_dev { > bool wakeup; > }; > =20 > -struct rt5033_battery { > - struct i2c_client *client; > - struct rt5033_dev *rt5033; > - struct regmap *regmap; > - struct power_supply *psy; > -}; > - > #endif /* __RT5033_H__ */ > --=20 > 2.39.2 >=20 --w66avb2qq2hrapvz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmRhZQcACgkQ2O7X88g7 +prJyA/+O1YQSYfVIfUyrW708AKFet4/dTSpu9Y9VZEuKZxWzYVOsvajBQi1vybJ +9lJ2FABRwTzwLOpR6tbEsXPBodDSP9WrrAquB35woUlPIMl/UQKsxDmRU4jYdci yVneUpa80i+sLBfmIB5zCxIjj9l93xN+JQ174PYfF7OJ7p1fhuKXducqkHgHM3aZ Ub33OJy3ArKahI8PQCA04uFoMjMGN8tML4ZPHXB7wfbvGEDfWbicMzb02TWu7D2Q uTEDxZgYjQnqeMOeD42J6dDQuVohrHCN9QS+U70glXMSLOS+HYSx99d/0PKhLojD ja0QZ4xA9lWxP9KE//kQNxlf34a2W7oawrIjWgoKXK3WXJ9D6vW4pTBdwjdRDQvV ZSktIUvvaft4zc9aZ4j5DMKI8lsjk2YI7nuGIS+/Y2Q368YQn+mW/akPHscVp6qK 7luonWrLqwH6nus3Ly3WPx9kUFZe0XylrQryJIfvxfi4zhsYr21izOIKhjEc7Xdv g3zNzYI8tR4MKFhlPMvCBk9JiP8yB+wZUCuHeQBeWWAt/zZuiGJMmiQL0pyonL/V 0+b+ba8db4DvaaM2DFfksC8/zBhzL4siHfX6NVBi5SUbtz8bcbnFAjUHf6xDdjAN zEHjM5iCnV/neMRoOrsSnMAht+y4DjAxbQ5Yt4ryPeYSrJ6h3/M= =onLL -----END PGP SIGNATURE----- --w66avb2qq2hrapvz--