mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Arnd Bergmann <arnd@arndb.de>, Hanjun Guo <guohanjun@huawei.com>,
	Joerg Roedel <jroedel@suse.de>,
	Robin Murphy <robin.murphy@arm.com>,
	Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 5/5] irqchip: gicv3: add a iort_pmsi_get_dev_id() prototype
Date: Tue, 16 May 2023 22:05:08 +0200	[thread overview]
Message-ID: <20230516200516.554663-5-arnd@kernel.org> (raw)
In-Reply-To: <20230516200516.554663-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

iort_pmsi_get_dev_id() has a __weak definition in the driver, and
an override in arm64 specific code, but the declaration is conditional
and not always seen when the copy in the driver gets built:

drivers/irqchip/irq-gic-v3-its-platform-msi.c:41:12: error: no previous prototype for 'iort_pmsi_get_dev_id' [-Werror=missing-prototypes]

Move the existing declaration out of the #ifdef block to ensure
it can be seen in all configurations.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/acpi_iort.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/acpi_iort.h b/include/linux/acpi_iort.h
index b43be0987b19..6b70d02bc5f9 100644
--- a/include/linux/acpi_iort.h
+++ b/include/linux/acpi_iort.h
@@ -26,13 +26,14 @@ int iort_register_domain_token(int trans_id, phys_addr_t base,
 			       struct fwnode_handle *fw_node);
 void iort_deregister_domain_token(int trans_id);
 struct fwnode_handle *iort_find_domain_token(int trans_id);
+int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id);
+
 #ifdef CONFIG_ACPI_IORT
 void acpi_iort_init(void);
 u32 iort_msi_map_id(struct device *dev, u32 id);
 struct irq_domain *iort_get_device_domain(struct device *dev, u32 id,
 					  enum irq_domain_bus_token bus_token);
 void acpi_configure_pmsi_domain(struct device *dev);
-int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id);
 void iort_get_rmr_sids(struct fwnode_handle *iommu_fwnode,
 		       struct list_head *head);
 void iort_put_rmr_sids(struct fwnode_handle *iommu_fwnode,
-- 
2.39.2


  parent reply	other threads:[~2023-05-16 20:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 20:05 [PATCH 1/5] irqchip: ftintc010: mark all function static Arnd Bergmann
2023-05-16 20:05 ` [PATCH 2/5] irqchip: mmp: remove non-DT codepath Arnd Bergmann
2023-06-17  6:39   ` [irqchip: irq/irqchip-next] irqchip/mmp: Remove " irqchip-bot for Arnd Bergmann
2023-05-16 20:05 ` [PATCH 3/5] irqchip: clps711x: remove unused clps711x_intc_init() function Arnd Bergmann
2023-06-17  6:39   ` [irqchip: irq/irqchip-next] irqchip/clps711x: Remove " irqchip-bot for Arnd Bergmann
2023-05-16 20:05 ` [PATCH 4/5] irqchip: mxs: include linux/irqchip/mxs.h Arnd Bergmann
2023-05-27 10:39   ` Shawn Guo
2023-06-17  6:39   ` [irqchip: irq/irqchip-next] irqchip/mxs: Include linux/irqchip/mxs.h irqchip-bot for Arnd Bergmann
2023-05-16 20:05 ` Arnd Bergmann [this message]
2023-05-18 13:19   ` [PATCH 5/5] irqchip: gicv3: add a iort_pmsi_get_dev_id() prototype Hanjun Guo
2023-06-17  6:39   ` [irqchip: irq/irqchip-next] irqchip/gicv3: Add " irqchip-bot for Arnd Bergmann
2023-05-17  7:06 ` [PATCH 1/5] irqchip: ftintc010: mark all function static Linus Walleij
2023-06-17  6:39 ` [irqchip: irq/irqchip-next] irqchip/ftintc010: Mark " irqchip-bot for Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516200516.554663-5-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=guohanjun@huawei.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome