mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: menglong8.dong@gmail.com
To: kuba@kernel.org
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	dsahern@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Menglong Dong <imagedong@tencent.com>
Subject: [PATCH net-next 0/3] net: tcp: add support of window shrink
Date: Wed, 17 May 2023 20:41:58 +0800	[thread overview]
Message-ID: <20230517124201.441634-1-imagedong@tencent.com> (raw)

From: Menglong Dong <imagedong@tencent.com>

For now, skb will be dropped when no memory, which makes client keep
retrans util timeout and it's not friendly to the users.

Therefore, now we force to receive one packet on current socket when
the protocol memory is out of the limitation. Then, this socket will
stay in 'no mem' status, util protocol memory is available.

When a socket is in 'no mem' status, it's receive window will become
0, which means window shrink happens. For the sender, it need to
cover this case, and we turn it into zero-window probe status.

In the origin logic, 0 probe is triggered only when there is no any
data in the retrans queue and the receive window can't hold the data
of the 1th packet in the send queue.

Now, let's change it and trigger the 0 probe in such cases:

- if the retrans queue has data and the 1th packet in it is not within
  the receive window, which is for window shrink case, as the shrinked
  window may can't cover the data in retrans queue.
- no data in the retrans queue and the 1th packet in the send queue is
  out of the end of the receive window

And the sysctl 'tcp_wnd_shrink' is also introduced. In order to keep
safe, we disable this feature by default.

*** BLURB HERE ***

Menglong Dong (3):
  net: tcp: add sysctl for controling tcp window shrink
  net: tcp: send zero-window when no memory
  net: tcp: handle window shrink properly

 include/net/sock.h         |  1 +
 include/net/tcp.h          | 22 ++++++++++++++++
 net/ipv4/sysctl_net_ipv4.c |  9 +++++++
 net/ipv4/tcp.c             |  3 +++
 net/ipv4/tcp_input.c       | 53 ++++++++++++++++++++++++++++++++++++++
 net/ipv4/tcp_output.c      | 10 +++++--
 net/ipv4/tcp_timer.c       |  4 +--
 7 files changed, 97 insertions(+), 5 deletions(-)

-- 
2.40.1


             reply	other threads:[~2023-05-17 12:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 12:41 menglong8.dong [this message]
2023-05-17 12:41 ` [PATCH net-next 1/3] net: tcp: add sysctl for controling tcp " menglong8.dong
2023-05-17 12:42 ` [PATCH net-next 2/3] net: tcp: send zero-window when no memory menglong8.dong
2023-05-17 14:44   ` Eric Dumazet
2023-05-18  2:14     ` Menglong Dong
2023-05-18 14:25     ` Menglong Dong
2023-05-17 12:42 ` [PATCH net-next 3/3] net: tcp: handle window shrink properly menglong8.dong
2023-05-17 14:47   ` Eric Dumazet
2023-05-18  2:34     ` Menglong Dong
2023-05-18 13:40       ` Neal Cardwell
2023-05-18 14:11         ` Menglong Dong
2023-05-18 16:03           ` Neal Cardwell
2023-05-20  9:07             ` Menglong Dong
2023-05-20 14:28               ` Neal Cardwell
2023-05-22  2:55                 ` Menglong Dong
2023-05-22 15:04                   ` Neal Cardwell
2023-05-23  8:59                     ` Menglong Dong
2023-05-23 13:27                       ` Neal Cardwell
2023-05-24 12:16                         ` Menglong Dong
2023-05-24 14:49                           ` Neal Cardwell
2023-05-23 10:26                     ` Eric Dumazet
2023-05-17 16:55   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230517124201.441634-1-imagedong@tencent.com \
    --to=menglong8.dong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=imagedong@tencent.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®