From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC0FC7EE2A for ; Sat, 20 May 2023 18:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbjETS1i (ORCPT ); Sat, 20 May 2023 14:27:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232181AbjETS1O (ORCPT ); Sat, 20 May 2023 14:27:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5A5010E7; Sat, 20 May 2023 11:26:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D76FD616D0; Sat, 20 May 2023 18:23:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F9C3C433EF; Sat, 20 May 2023 18:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684607013; bh=nBR+ZTXbOkda34DbC4KgZEMyrRRAzRbO4Aeh7LI5JeI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NuhZwbD1FBVUUrmRNklZvFpxAbqaYIHP23DPZ4UXs4mC0TE9KMr8gJyVqbFWk6R3n sJzJ7d/NuY8xnS9yAbPl/msggwUqYuZWsqe6KS7mng8E4G3XhktyWwatWiEnFT8/W/ FUzIiZ7Dd0MvpD02tcJeti7I7TauckgiC06DIVrZqfY3y5edgB+aEE6ESkYXQhclwN pWIWsiWMYrX1RQF5r4Eb0CVLXNbj8Pake+CrZkIMbIKVW0xtFl7G59h3B/YFPBynu7 hyRxKyMF9wNIRuGVyVAuN3dmEGu7XmrQu9oVBmoQoOzOKVakeHNq0xyAjhu1oHgLdP xq4HFyYTD71hg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Hans Verkuil , Sasha Levin , mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 3/8] media: rcar-vin: Select correct interrupt mode for V4L2_FIELD_ALTERNATE Date: Sat, 20 May 2023 14:23:07 -0400 Message-Id: <20230520182312.851751-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230520182312.851751-1-sashal@kernel.org> References: <20230520182312.851751-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Niklas Söderlund [ Upstream commit e10707d5865c90d3dfe4ef589ce02ff4287fef85 ] When adding proper support for V4L2_FIELD_ALTERNATE it was missed that this field format should trigger an interrupt for each field, not just for the whole frame. Fix this by marking it as progressive in the capture setup, which will then select the correct interrupt mode. Tested on both Gen2 and Gen3 with the result of a doubling of the frame rate for V4L2_FIELD_ALTERNATE. From a PAL video source the frame rate is now 50, which is expected for alternate field capture. Signed-off-by: Niklas Söderlund Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/rcar-vin/rcar-dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index 692dea300b0de..63c61c704446b 100644 --- a/drivers/media/platform/rcar-vin/rcar-dma.c +++ b/drivers/media/platform/rcar-vin/rcar-dma.c @@ -645,11 +645,9 @@ static int rvin_setup(struct rvin_dev *vin) case V4L2_FIELD_SEQ_TB: case V4L2_FIELD_SEQ_BT: case V4L2_FIELD_NONE: - vnmc = VNMC_IM_ODD_EVEN; - progressive = true; - break; case V4L2_FIELD_ALTERNATE: vnmc = VNMC_IM_ODD_EVEN; + progressive = true; break; default: vnmc = VNMC_IM_ODD; -- 2.39.2