From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A722C77B73 for ; Sun, 21 May 2023 19:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbjEUTVB (ORCPT ); Sun, 21 May 2023 15:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbjEUTU6 (ORCPT ); Sun, 21 May 2023 15:20:58 -0400 Received: from outbound-smtp16.blacknight.com (outbound-smtp16.blacknight.com [46.22.139.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6AA9D7 for ; Sun, 21 May 2023 12:20:54 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp16.blacknight.com (Postfix) with ESMTPS id 483691C47D4 for ; Sun, 21 May 2023 20:20:53 +0100 (IST) Received: (qmail 13105 invoked from network); 21 May 2023 19:20:52 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[93.89.247.161]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 May 2023 19:20:52 -0000 Date: Sun, 21 May 2023 20:20:46 +0100 From: Mel Gorman To: Raghavendra K T Cc: Vlastimil Babka , Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML Subject: Re: [PATCH 0/4] Follow-up "Fix excessive CPU usage during compaction" Message-ID: <20230521192046.pduhkcv2u3j5dfbl@techsingularity.net> References: <6d62686f-964d-342c-e085-0eae2555cc54@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <6d62686f-964d-342c-e085-0eae2555cc54@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 19, 2023 at 12:13:11PM +0530, Raghavendra K T wrote: > On 5/15/2023 5:03 PM, Mel Gorman wrote: > > The series "Fix excessive CPU usage during compaction" [1] attempted to > > fix a bug [2] but Vlastimil noted that the fix was incomplete [3]. While > > the series was merged, fast_find_migrateblock was still disabled. This > > series should fix the corner cases and allow 95e7a450b819 ("Revert > > "mm/compaction: fix set skip in fast_find_migrateblock"") to be safely > > reverted. Details on how many pageblocks are rescanned are in the > > changelog of the last patch. > > > > [1] https://lore.kernel.org/r/20230125134434.18017-1-mgorman@techsingularity.net > > [2] https://bugzilla.suse.com/show_bug.cgi?id=1206848 > > [3] https://lore.kernel.org/r/a55cf026-a2f9-ef01-9a4c-398693e048ea@suse.cz > > > > mm/compaction.c | 24 ++++++++++-------------- > > 1 file changed, 10 insertions(+), 14 deletions(-) > > > > Hello Mel, > > Not sure how much this info would help, (also I saw it is in Andrew's > tree already) But was curious to evaluate the patchset from perf > perspective, and I have run mmtest usemem so here is the result (Only > for compact cases). > > > Thanks Raghavendra! -- Mel Gorman SUSE Labs