From: Wyes Karny <wyes.karny@amd.com>
To: <ray.huang@amd.com>, <rafael@kernel.org>, <viresh.kumar@linaro.org>
Cc: <Mario.Limonciello@amd.com>, <Jinzhou.Su@amd.com>,
<Perry.Yuan@amd.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Wyes Karny <wyes.karny@amd.com>
Subject: [PATCH 2/2] cpufreq/amd-pstate: Remove unnecessary active state checks
Date: Mon, 22 May 2023 06:33:25 +0000 [thread overview]
Message-ID: <20230522063325.80193-3-wyes.karny@amd.com> (raw)
In-Reply-To: <20230522063325.80193-1-wyes.karny@amd.com>
Some functions are only specific to amd_pstate active mode driver. This
functions cannot be called from passive/guided mode paths, therefore
remove these unnecessary checks.
Fixes: d4da12f8033a ("cpufreq: amd-pstate: implement amd pstate cpu online and offline callback")
Fixes: 50ddd2f78269 ("cpufreq: amd-pstate: implement suspend and resume callbacks")
Signed-off-by: Wyes Karny <wyes.karny@amd.com>
---
drivers/cpufreq/amd-pstate.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 8c72f95ac315..fda66a206d26 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1209,10 +1209,8 @@ static int amd_pstate_epp_cpu_online(struct cpufreq_policy *policy)
pr_debug("AMD CPU Core %d going online\n", cpudata->cpu);
- if (cppc_state == AMD_PSTATE_ACTIVE) {
- amd_pstate_epp_reenable(policy->cpu, cpudata);
- cpudata->suspended = false;
- }
+ amd_pstate_epp_reenable(policy->cpu, cpudata);
+ cpudata->suspended = false;
return 0;
}
@@ -1255,8 +1253,7 @@ static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy)
if (cpudata->suspended)
return 0;
- if (cppc_state == AMD_PSTATE_ACTIVE)
- amd_pstate_epp_offline(policy);
+ amd_pstate_epp_offline(policy);
return 0;
}
@@ -1273,10 +1270,6 @@ static int amd_pstate_epp_suspend(struct cpufreq_policy *policy)
struct amd_cpudata *cpudata = policy->driver_data;
int ret;
- /* avoid suspending when EPP is not enabled */
- if (cppc_state != AMD_PSTATE_ACTIVE)
- return 0;
-
/* set this flag to avoid setting core offline*/
cpudata->suspended = true;
--
2.34.1
next prev parent reply other threads:[~2023-05-22 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 6:33 [PATCH 0/2] amd-pstate: amd_pstate related fixes Wyes Karny
2023-05-22 6:33 ` [PATCH 1/2] cpufreq/amd-pstate: Write CPPC enable bit for each core Wyes Karny
2023-05-22 8:16 ` Huang Rui
2023-05-26 3:28 ` kernel test robot
2023-05-22 6:33 ` Wyes Karny [this message]
2023-05-22 7:27 ` [PATCH 2/2] cpufreq/amd-pstate: Remove unnecessary active state checks Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522063325.80193-3-wyes.karny@amd.com \
--to=wyes.karny@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®