From: John Ogness <john.ogness@linutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Petr Mladek <pmladek@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>,
linux-serial@vger.kernel.org
Subject: [PATCH tty v1 2/8] serial: core: lock port for stop_rx() in uart_suspend_port()
Date: Thu, 25 May 2023 11:37:53 +0206 [thread overview]
Message-ID: <20230525093159.223817-3-john.ogness@linutronix.de> (raw)
In-Reply-To: <20230525093159.223817-1-john.ogness@linutronix.de>
The uarts_ops stop_rx() callback expects that the port->lock is
taken and interrupts are disabled.
Fixes: c9d2325cdb92 ("serial: core: Do stop_rx in suspend path for console if console_suspend is disabled")
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
drivers/tty/serial/serial_core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 4b98d13555c0..37ad53616372 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2333,8 +2333,11 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
* able to Re-start_rx later.
*/
if (!console_suspend_enabled && uart_console(uport)) {
- if (uport->ops->start_rx)
+ if (uport->ops->start_rx) {
+ spin_lock_irq(&uport->lock);
uport->ops->stop_rx(uport);
+ spin_unlock_irq(&uport->lock);
+ }
goto unlock;
}
--
2.30.2
next prev parent reply other threads:[~2023-05-25 9:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 9:31 [PATCH tty v1 0/8] synchronize UART_IER access against console write John Ogness
2023-05-25 9:31 ` [PATCH tty v1 1/8] serial: 8250: lock port in startup() callbacks John Ogness
2023-05-25 9:31 ` John Ogness [this message]
2023-05-25 17:47 ` [PATCH tty v1 2/8] serial: core: lock port for stop_rx() in uart_suspend_port() Vijaya Krishna Nivarthi (Temp) (QUIC)
2023-05-25 20:37 ` Doug Anderson
2023-05-25 9:31 ` [PATCH tty v1 3/8] serial: 8250: lock port for stop_rx() in omap8250_irq() John Ogness
2023-05-26 9:00 ` Tony Lindgren
2023-05-25 9:31 ` [PATCH tty v1 4/8] serial: core: lock port for start_rx() in uart_resume_port() John Ogness
2023-05-25 16:07 ` Doug Anderson
2023-05-25 20:38 ` Doug Anderson
2023-05-26 8:09 ` John Ogness
2023-05-25 9:31 ` [PATCH tty v1 5/8] serial: 8250: lock port for rx_dma() callback John Ogness
2023-05-25 9:31 ` [PATCH tty v1 6/8] serial: 8250: lock port for omap8250_restore_regs() John Ogness
2023-05-25 9:31 ` [PATCH tty v1 7/8] serial: 8250: lock port for UART_IER access in omap8250_irq() John Ogness
2023-05-26 9:01 ` Tony Lindgren
2023-05-25 9:31 ` [PATCH tty v1 8/8] serial: 8250: synchronize and annotate UART_IER access John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525093159.223817-3-john.ogness@linutronix.de \
--to=john.ogness@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=quic_vnivarth@quicinc.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®