From: Lee Jones <lee@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: hide suspend/resume functions in #ifdef
Date: Thu, 25 May 2023 11:31:24 +0100 [thread overview]
Message-ID: <20230525103124.GC9691@google.com> (raw)
In-Reply-To: <20230516202746.561111-1-arnd@kernel.org>
On Tue, 16 May 2023, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_PM is disabled, the prototypes for these two functions
> are not visible:
>
> drivers/mfd/intel-lpss.c:482:5: error: no previous prototype for 'intel_lpss_suspend' [-Werror=missing-prototypes]
> 482 | int intel_lpss_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~
> drivers/mfd/intel-lpss.c:503:5: error: no previous prototype for 'intel_lpss_resume' [-Werror=missing-prototypes]
> 503 | int intel_lpss_resume(struct device *dev)
>
> Add the same #ifdef around the definition of the unused functions,
> which avoids the warning and slightly reduces the code size.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/intel-lpss.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-05-25 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 20:27 Arnd Bergmann
2023-05-25 10:31 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525103124.GC9691@google.com \
--to=lee@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome