mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugo Villeneuve <hugo@hugovil.com>
To: andy.shevchenko@gmail.com
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	jirislaby@kernel.org, jringle@gridpoint.com,
	tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v3 11/11] serial: sc16is7xx: add dump registers function
Date: Thu, 25 May 2023 15:49:46 -0400	[thread overview]
Message-ID: <20230525154946.98829ff5bda64d7c723ed6ff@hugovil.com> (raw)
In-Reply-To: <ZG9F8xsPqs2ZWfED@surfacebook>

On Thu, 25 May 2023 14:26:43 +0300
andy.shevchenko@gmail.com wrote:

> Thu, May 25, 2023 at 12:03:25AM -0400, Hugo Villeneuve kirjoitti:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > With this driver, it is very hard to debug the registers using
> > the /sys/kernel/debug/regmap interface.
> > 
> > The main reason is that bits 0 and 1 of the register address
> > correspond to the channels bits, so the register address itself starts
> > at bit 2, so we must 'mentally' shift each register address by 2 bits
> > to get its offset.
> > 
> > Also, only channels 0 and 1 are supported, so combinations of bits
> > 0 and 1 being 10b and 11b are invalid, and the display of these
> > registers is useless.
> > 
> > For example:
> > 
> > cat /sys/kernel/debug/regmap/spi0.0/registers
> > 04: 10 -> Port 0, register offset 1
> > 05: 10 -> Port 1, register offset 1
> > 06: 00 -> Port 2, register offset 1 -> invalid
> > 07: 00 -> port 3, register offset 1 -> invalid
> > ...
> > 
> > Add a debug module parameter to call a custom dump function for each
> > port registers after the probe phase to help debug.
> 
> Not sure about this. Can we rather create an abstract mapping on regmap?
> (Something like gpio-pca953x.c has)

Hi,
maybe we can, but more like they do in the driver max310x.c (single, dual and quad UART versions).

I will look into it, but it will probably be a patch that affects a lot of the code, and that I would like to submit separately after this serie, and so I will probably simply drop this current patch (11/11) since it will not be needed anymore.

Hugo.

  reply	other threads:[~2023-05-25 19:50 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  4:03 [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 01/11] serial: sc16is7xx: fix syntax error in comments Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 02/11] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 03/11] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-05-25 11:02   ` Ilpo Järvinen
2023-05-25 13:45     ` Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 04/11] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-05-25 10:30   ` andy.shevchenko
2023-05-25 13:18     ` Hugo Villeneuve
2023-05-25 11:05   ` Ilpo Järvinen
2023-05-25 14:05     ` Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 05/11] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-05-25 11:20   ` Ilpo Järvinen
2023-05-25 15:10     ` Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 06/11] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-05-25 11:10   ` andy.shevchenko
2023-05-25 14:24     ` Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 07/11] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-05-25 11:11   ` andy.shevchenko
2023-05-25 14:34     ` Hugo Villeneuve
2023-05-25 15:15       ` Conor Dooley
2023-05-26 18:28       ` andy.shevchenko
2023-05-25  4:03 ` [PATCH v3 08/11] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-05-25 11:19   ` andy.shevchenko
2023-05-25 15:02     ` Hugo Villeneuve
2023-05-26 18:34       ` andy.shevchenko
2023-05-25 12:03   ` Ilpo Järvinen
2023-05-25 15:19     ` Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 09/11] serial: sc16is7xx: add I/O register translation offset Hugo Villeneuve
2023-05-25 11:22   ` andy.shevchenko
2023-05-25 15:31     ` Hugo Villeneuve
2023-05-25 17:20       ` Hugo Villeneuve
2023-05-26 18:36         ` andy.shevchenko
2023-05-25 12:10   ` Ilpo Järvinen
2023-05-25 15:25     ` Hugo Villeneuve
2023-05-25  4:03 ` [PATCH v3 10/11] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-05-25 12:17   ` Ilpo Järvinen
2023-05-25  4:03 ` [PATCH v3 11/11] serial: sc16is7xx: add dump registers function Hugo Villeneuve
2023-05-25 11:26   ` andy.shevchenko
2023-05-25 19:49     ` Hugo Villeneuve [this message]
2023-05-26 18:38       ` andy.shevchenko
2023-05-28 11:56   ` Greg KH
2023-05-25 10:27 ` [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements andy.shevchenko
2023-05-25 13:26   ` Hugo Villeneuve
2023-05-25 13:37     ` Andy Shevchenko
2023-05-25 13:39       ` Hugo Villeneuve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525154946.98829ff5bda64d7c723ed6ff@hugovil.com \
    --to=hugo@hugovil.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=jringle@gridpoint.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.perczak@camlintechnologies.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tomasz.mon@camlingroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®