mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Owen Yang <ecs.taipeikernel@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bob Moragues <moragues@google.com>,
	Abner Yen <abner.yen@ecs.com.tw>,
	Doug Anderson <dianders@chromium.org>,
	Matthias Kaehlcke <mka@google.com>,
	Stephen Boyd <swboyd@chromium.org>, Harvey <hunge@google.com>,
	Gavin Lee <gavin.lee@ecs.com.tw>,
	Owen Yang <ecs.taipeikernel@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org
Subject: [PATCH v1] drivers: pci: quirks: Add suspend fixup for SSD on sc7280
Date: Thu, 25 May 2023 16:35:12 +0800	[thread overview]
Message-ID: <20230525163448.v1.1.Id388e4e2aa48fc56f9cd2d413aabd461ff81d615@changeid> (raw)

Implement this workaround until Qualcomm fixed the
 correct NVMe suspend process.

Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
---

 drivers/pci/quirks.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index f4e2a88729fd..b57876dc2624 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5945,6 +5945,16 @@ static void nvidia_ion_ahci_fixup(struct pci_dev *pdev)
 }
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0ab8, nvidia_ion_ahci_fixup);
 
+/* In Qualcomm 7c gen 3 sc7280 platform. Some of the SSD won't enter
+ * the correct ASPM state properly. Therefore. Implement this workaround
+ * until Qualcomm fixed the correct NVMe suspend process*/
+static void phison_suspend_fixup(struct pci_dev *pdev)
+{
+	msleep(30);
+}
+DECLARE_PCI_FIXUP_SUSPEND(0x1987, 0x5013, phison_suspend_fixup);
+DECLARE_PCI_FIXUP_SUSPEND(0x1987, 0x5015, phison_suspend_fixup);
+
 static void rom_bar_overlap_defect(struct pci_dev *dev)
 {
 	pci_info(dev, "working around ROM BAR overlap defect\n");
-- 
2.17.1


             reply	other threads:[~2023-05-25  8:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  8:35 Owen Yang [this message]
2023-05-25 22:10 ` Bjorn Helgaas
     [not found]   ` <CAPao8GJNbXnh1R2-9rueMygyYyy-r3kqvQ55xdN61E7m6_dkdw@mail.gmail.com>
2023-05-29 12:23     ` Bjorn Helgaas
2023-05-30 21:06     ` Matthias Kaehlcke
2023-05-29 16:48 ` Manivannan Sadhasivam
2023-05-30 21:17   ` Matthias Kaehlcke
2023-05-31  6:46     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525163448.v1.1.Id388e4e2aa48fc56f9cd2d413aabd461ff81d615@changeid \
    --to=ecs.taipeikernel@gmail.com \
    --cc=abner.yen@ecs.com.tw \
    --cc=bhelgaas@google.com \
    --cc=dianders@chromium.org \
    --cc=gavin.lee@ecs.com.tw \
    --cc=hunge@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mka@google.com \
    --cc=moragues@google.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®