From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D22C77B73 for ; Fri, 26 May 2023 13:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243350AbjEZNJd (ORCPT ); Fri, 26 May 2023 09:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236978AbjEZNJb (ORCPT ); Fri, 26 May 2023 09:09:31 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7580B198; Fri, 26 May 2023 06:09:30 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-96f8d485ef3so112332266b.0; Fri, 26 May 2023 06:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685106569; x=1687698569; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zFJ2wzNIGZ0KOStcSuewNy9zLZfz/DVIl8h5862j09g=; b=SZ8Ij6ruFkxE5HmAzgORE4Zkm0chc0YtI3Dj9C86P75v1dVCrd3X+EP+Zhz1kOlJRT V5wpit7vQGPj+Jpm6jO4zNROI/iJ3ukfhNByE8Oc1Qpj5SyevKXEmwCzLlGHR5FQ3R8P a3wuY6rXAtU7RtdzSUpZGwmktFmiIbevWlP5JunqIMuoaGA2dDldcliaVYH6NMCdXHte BnF80tXTSHKKwK6Of5k6kM7pThauCgTn9nkotu6PGjrHemlmR8MysFYpDTh8SrNQwBHL CY2yGWrUzSz20HHqBa3w8dM2Cj7y7Nb8AvPgvRBDb1UAvQJ1NfOuNXHgXPGAgUB0wwnM 7Mvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685106569; x=1687698569; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zFJ2wzNIGZ0KOStcSuewNy9zLZfz/DVIl8h5862j09g=; b=fbe6HL3fke5QDryiUWJfW7JZI7Q879LkmpFy7Pzcq+ry/JJARpKcjBeur6tp5XxWAN nJFexeIHZQVlFNnK4qf56/0HiL4YxsMhLsjgpf4I7za7l+pkRdvQRwfwFKXsXTgvkxcM 40IQAvsqhPx1dg004GtbMzNEGeaGlCw/8W/6tvWOEdZgNbm+qjNXP8eTCScEpBXCJVZ4 ONM6K2x4VwLwZ/mQRFgTUS9lVj55fFQif1UDMaM9bgznEh+9hmVlUWGHXADaIut5zDo5 /hXgXhX1yhb4n171XYpQh0LnYMkoT3ZoSU/yF2VlxTqlQjt+VpjAx93SZEnkwjaPfZc0 kYJw== X-Gm-Message-State: AC+VfDy9hi8B/b5/yaJ2mepxWoxcx393dLVC000wHj6ltT8qDqwdZQDG zbun7Bi9USDhlesmY7A8gLg= X-Google-Smtp-Source: ACHHUZ5Na1tqMh44XsGjWcNaXiLrMmEVPuZshBdTgVvbPjvRA8qYslkhuP9hKJli3isZlAlI28LZFg== X-Received: by 2002:a17:907:1621:b0:96f:b9c9:c8b7 with SMTP id hb33-20020a170907162100b0096fb9c9c8b7mr1999316ejc.46.1685106568533; Fri, 26 May 2023 06:09:28 -0700 (PDT) Received: from skbuf ([188.27.184.189]) by smtp.gmail.com with ESMTPSA id le8-20020a170907170800b0096f803afbe3sm2164022ejc.66.2023.05.26.06.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 06:09:28 -0700 (PDT) Date: Fri, 26 May 2023 16:09:25 +0300 From: Vladimir Oltean To: arinc9.unal@gmail.com Cc: Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Richard van Schagen , Richard van Schagen , Frank Wunderlich , Bartel Eerdekens , erkin.bozoglu@xeront.com, mithat.guner@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 15/30] net: dsa: mt7530: set TRGMII RD TAP if trgmii is being used Message-ID: <20230526130925.g6w3tbxunoamfmha@skbuf> References: <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522121532.86610-16-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230522121532.86610-16-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 03:15:17PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > This code sets the Read Data (RD) TAP value to 16 for all TRGMII control > registers. > > The for loop iterates over all the TRGMII control registers, and > mt7530_rmw() function is used to perform a read-modify-write operation on > each register's RD_TAP field to set its value to 16. > > This operation is used to tune the timing of the read data signal in > TRGMII to match the TX signal of the link partner. > > Run this if trgmii is being used. Since this code doesn't lower the > driving, there's no apparent benefit to run this if trgmii is not being > used. > > Add a comment to explain the code. > > Thanks to 趙皎宏 (Landen Chao) for pointing out what the code does. > > Tested-by: Arınç ÜNAL > Signed-off-by: Arınç ÜNAL > --- Reviewed-by: Vladimir Oltean