From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Luczaj <mhal@rbox.co>
Subject: [PATCH v2 0/3] KVM: x86: Out-of-bounds access in kvm_recalculate_phys_map()
Date: Fri, 26 May 2023 16:50:45 -0700 [thread overview]
Message-ID: <20230526235048.2842761-1-seanjc@google.com> (raw)
v2 of Michal's fix for a TOCTOU bug in kvm_recalculate_phys_map(). Not
fully tested (will do that next week), though I did confirm the reworked
selftest can hit the bug. Posting a bit prematurely as I have a long weekend
and I don't want Michal to do any duplicate work.
In Michal's words...
kvm_recalculate_apic_map() creates the APIC map iterating over the list of
vCPUs twice. First to find the max APIC ID and allocate a max-sized buffer,
then again, calling kvm_recalculate_phys_map() for each vCPU. This opens a
race window: value of max APIC ID can increase _after_ the buffer was
allocated.
Michal Luczaj (1):
KVM: selftests: Add test for race in kvm_recalculate_apic_map()
Sean Christopherson (2):
KVM: x86: Bail from kvm_recalculate_phys_map() if x2APIC ID is
out-of-bounds
KVM: x86: Retry APIC optimized map recalc if vCPU is added/enabled
arch/x86/kvm/lapic.c | 49 ++++++++++--
tools/testing/selftests/kvm/Makefile | 1 +
.../kvm/x86_64/recalc_apic_map_race.c | 76 +++++++++++++++++++
3 files changed, 120 insertions(+), 6 deletions(-)
create mode 100644 tools/testing/selftests/kvm/x86_64/recalc_apic_map_race.c
base-commit: 39428f6ea9eace95011681628717062ff7f5eb5f
--
2.41.0.rc0.172.g3f132b7071-goog
next reply other threads:[~2023-05-26 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 23:50 Sean Christopherson [this message]
2023-05-26 23:50 ` [PATCH v2 1/3] KVM: x86: Bail from kvm_recalculate_phys_map() if x2APIC ID is out-of-bounds Sean Christopherson
2023-05-26 23:50 ` [PATCH v2 2/3] KVM: x86: Retry APIC optimized map recalc if vCPU is added/enabled Sean Christopherson
2023-05-26 23:50 ` [PATCH v2 3/3] KVM: selftests: Add test for race in kvm_recalculate_apic_map() Sean Christopherson
2023-06-01 23:11 ` Sean Christopherson
2023-06-01 23:40 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526235048.2842761-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®