From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: arnd@arndb.de
Cc: hch@lst.de, andriy.shevchenko@intel.com,
dan.j.williams@intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] Enclosure interface cleanups
Date: Tue, 30 May 2023 16:02:21 +0200 [thread overview]
Message-ID: <20230530140223.13994-1-mariusz.tkaczyk@linux.intel.com> (raw)
Hi Arnd,
While looking into adding Native PCIE Enclosure Management (NPEM) support
behind the existing enclosure ABI, I noticed a few opportunities for
cleanups.
Changes since v1[1] + internal review:
- Keep reporting the cached version of ecomp->active (Dan).
- Preserve cached values in ecomp, drop patch 2 (Dan).
- Add comment documenting cached ecomp->active (Dan).
- Move ATTRS macros close to appropriate _show and _store functions (Andy).
- Make comment shorter (Christoph).
- Update patch2 title (Christoph).
[1] https://lore.kernel.org/linux-pci/20221117163407.28472-1-mariusz.tkaczyk@linux.intel.com/
[2] https://lore.kernel.org/linux-kernel/20230524111231.14506-3-mariusz.tkaczyk@linux.intel.com/
Mariusz Tkaczyk (2):
misc: enclosure: remove get_active callback
misc: enclosure: update sysfs api
drivers/misc/enclosure.c | 84 ++++++++++++++++++---------------------
include/linux/enclosure.h | 2 -
2 files changed, 39 insertions(+), 47 deletions(-)
--
2.26.2
next reply other threads:[~2023-05-30 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 14:02 Mariusz Tkaczyk [this message]
2023-05-30 14:02 ` [PATCH v3 1/2] misc: enclosure: remove get_active callback Mariusz Tkaczyk
2023-05-30 14:36 ` Christoph Hellwig
2023-07-05 7:28 ` Mariusz Tkaczyk
2023-05-30 14:02 ` [PATCH v3 2/2] misc: enclosure: use DEVICE_ATTR_RW* macros Mariusz Tkaczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530140223.13994-1-mariusz.tkaczyk@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®