From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A775C77B7C for ; Wed, 31 May 2023 08:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234976AbjEaIyX (ORCPT ); Wed, 31 May 2023 04:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235160AbjEaIyE (ORCPT ); Wed, 31 May 2023 04:54:04 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 820BE121; Wed, 31 May 2023 01:54:00 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EDA61042; Wed, 31 May 2023 01:54:45 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C0D33F663; Wed, 31 May 2023 01:53:58 -0700 (PDT) Date: Wed, 31 May 2023 09:53:56 +0100 From: Sudeep Holla To: Florian Fainelli Cc: Conor Dooley , stable@vger.kernel.org, Pierre Gondois , Sudeep Holla , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , "open list:GENERIC ARCHITECTURE TOPOLOGY" Subject: Re: [PATCH stable 6.3 v2] arch_topology: Remove early cacheinfo error message if -ENOENT Message-ID: <20230531085356.ru4fmtawyxo5cq5s@bogus> References: <20230530201955.848176-1-florian.fainelli@broadcom.com> <20230530-basically-wildly-84415a94171d@spud> <72d84100-55cf-566d-8301-7147ce14b1e9@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72d84100-55cf-566d-8301-7147ce14b1e9@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 03:42:45PM -0700, Florian Fainelli wrote: > Hi Conor, > > On 5/30/23 14:39, Conor Dooley wrote: > > Yo Florian, > > > > On Tue, May 30, 2023 at 01:19:55PM -0700, Florian Fainelli wrote: > > > From: Pierre Gondois > > > > > > commit 3522340199cc060b70f0094e3039bdb43c3f6ee1 upstream > > > > > > fetch_cache_info() tries to get the number of cache leaves/levels > > > for each CPU in order to pre-allocate memory for cacheinfo struct. > > > Allocating this memory later triggers a: > > > 'BUG: sleeping function called from invalid context' > > > in PREEMPT_RT kernels. > > > > > > If there is no cache related information available in DT or ACPI, > > > fetch_cache_info() fails and an error message is printed: > > > 'Early cacheinfo failed, ret = ...' > > > > > > Not having cache information should be a valid configuration. > > > Remove the error message if fetch_cache_info() fails with -ENOENT. > > > > > > Suggested-by: Conor Dooley > > > Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/ > > > Signed-off-by: Pierre Gondois > > > Reviewed-by: Conor Dooley > > > Link: https://lore.kernel.org/r/20230414081453.244787-4-pierre.gondois@arm.com > > > Signed-off-by: Sudeep Holla > > > Signed-off-by: Florian Fainelli > > > > How come this now needs a backport? Did the rest of the series get > > backported, but not this one since it has no fixes tag? > > Humm, indeed, this has been present in v6.3.2 since I requested it to be > included. The error that I saw this morning was not -ENOENT, but -EINVAL. > > With those patches applied, no more -EINVAL: > > cacheinfo: Allow early level detection when DT/ACPI info is missing/broken > cacheinfo: Add arm64 early level initializer implementation > cacheinfo: Add arch specific early level initializer > cacheinfo: Add use_arch[|_cache]_info field/function > > I will submit those shortly unless we think they better not be in 6.3, in > which case it would be nice to silence those -EINVAL errors. I prefer this option instead of back porting all the above 4 as there are some pending fixes for the issues found in those patches. I am fine if Greg is happy with the backport, so no strong rejection from my side :). -- Regards, Sudeep