From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D42C77B7A for ; Wed, 31 May 2023 13:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236885AbjEaNtJ (ORCPT ); Wed, 31 May 2023 09:49:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236858AbjEaNsa (ORCPT ); Wed, 31 May 2023 09:48:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA5D1BC; Wed, 31 May 2023 06:44:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC92863B3B; Wed, 31 May 2023 13:43:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4170C4339B; Wed, 31 May 2023 13:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685540612; bh=JtvoY6/oALQcjZPcw1kKEBD80K+TBPqLvWOnnsP8LhU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tp7icQ8eKxlCzFAvkHG8Y4IpK71rW3lXFQ4Z7rLyIrG9Hj1WI/CDPvDiPZDnKnbjr LL8oCOCL7jpCjf9fcUGn5l4ikTH/CPxUplF3M/0YDPiL9fsqabZapf9HxO4E2UN/bJ mwqktQ/jtkmvGzE8vz6Hlu8Ymhu9J89X/979MJ8AqzXbjMYDF0CZuHRLRvY0UVxfqb scKqLgwawzvnhmmmfjl45NT5GplP/J0BmdK0HY32E/4VvL2euAvrwFfkYlJY/2eVly um7phvbzcbjB/qxwPT7IlYBQZDVtjRQofxalJLwiRAep2qFmLPGho7lQofEXpJPd79 /RZSqYic0IV3Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Osama Muhammad , Sasha Levin , lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH AUTOSEL 5.15 08/24] regulator: Fix error checking for debugfs_create_dir Date: Wed, 31 May 2023 09:43:04 -0400 Message-Id: <20230531134320.3384102-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230531134320.3384102-1-sashal@kernel.org> References: <20230531134320.3384102-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Osama Muhammad [ Upstream commit 2bf1c45be3b8f3a3f898d0756c1282f09719debd ] This patch fixes the error checking in core.c in debugfs_create_dir. The correct way to check if an error occurred is 'IS_ERR' inline function. Signed-off-by: Osama Muhammad --- drivers/regulator/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 9ddb80d10dee3..211ab227b000c 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -5193,7 +5193,7 @@ static void rdev_init_debugfs(struct regulator_dev *rdev) } rdev->debugfs = debugfs_create_dir(rname, debugfs_root); - if (!rdev->debugfs) { + if (IS_ERR(rdev->debugfs)) { rdev_warn(rdev, "Failed to create debugfs directory\n"); return; } @@ -6103,7 +6103,7 @@ static int __init regulator_init(void) ret = class_register(®ulator_class); debugfs_root = debugfs_create_dir("regulator", NULL); - if (!debugfs_root) + if (IS_ERR(debugfs_root)) pr_warn("regulator: Failed to create debugfs directory\n"); #ifdef CONFIG_DEBUG_FS -- 2.39.2