From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1D2C77B73 for ; Wed, 31 May 2023 14:16:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237614AbjEaOQG (ORCPT ); Wed, 31 May 2023 10:16:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237621AbjEaOPq (ORCPT ); Wed, 31 May 2023 10:15:46 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C878718D; Wed, 31 May 2023 07:13:20 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34V5CpaG031404; Wed, 31 May 2023 09:12:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=DfcZshtC/3kePJgZElnsMbSUMBBpHznHMh0D64IdoII=; b=ApqQ+JFfSzg+1JB9vTTtQ6kONI8wr2UWK94lbyvCuEPStuZp7bhenjNYydsOQrbr5cW9 QOeLN+yWeBz+VuHFGE3W0W+IIpeH4c0Gz4lIMFAm+vj+RRdn7QPmycW6j08R/dHZ/qFs 7ldmOfOGYsgkGbI4kSbTr7q3WdgUkBR4YdWzgzTseHkNtB5IgncTzjDVi9cxQaDFRb+K QZR6u8tTT3IrbG4Q6QdABwZRbLTRkK3hJjGkmu7RqkvUhv26RrjiqdN1GM5Bl/w8a6Td ep+DcqVcOsaWKRNeU7dEo9Fd0R27E4SIvL13c1KS1IMbhJ1ZFwrNnRvyt8c9MgVf+1oh tQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3que9mvtw7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 May 2023 09:12:09 -0500 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 31 May 2023 15:12:07 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 31 May 2023 15:12:07 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 598FD475; Wed, 31 May 2023 14:12:07 +0000 (UTC) Date: Wed, 31 May 2023 14:12:07 +0000 From: Charles Keepax To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 2/6] dt-bindings: sound: cirrus,cs42l43: Add initial DT binding Message-ID: <20230531141207.GJ68926@ediswmail.ad.cirrus.com> References: <20230530122112.1314458-1-ckeepax@opensource.cirrus.com> <20230530122112.1314458-3-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: hIXSRhjnKWNOVq-ly_WiPUo81d5fSQGO X-Proofpoint-ORIG-GUID: hIXSRhjnKWNOVq-ly_WiPUo81d5fSQGO X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2023 at 11:02:24AM +0200, Krzysztof Kozlowski wrote: > On 30/05/2023 14:21, Charles Keepax wrote: > > + cirrus,bias-sense-ua: > > "ua" looks like microamp. If so, microamp instead: > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml > > > + pinctrl: > > + type: object > > + > > + allOf: > > Drop allOf, just "$ref: ......" > > > + - $ref: /schemas/pinctrl/pinctrl.yaml# > > + > > + additionalProperties: false > > Also drop blank lines between these three above. > > > + patternProperties: > > + "-state$": > > Use consistent quotes, either " or ' everywhere > Thanks, will fix those all up for v3. Thanks, Charles