From: Kees Cook <keescook@chromium.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: azeemshaikh38@gmail.com, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w1: sgi_w1: Replace all non-returning strlcpy with strscpy
Date: Thu, 1 Jun 2023 11:25:45 -0700 [thread overview]
Message-ID: <202306011125.D66A54586E@keescook> (raw)
In-Reply-To: <5d9cf207-7984-6dd0-731f-e301aa7b25c2@linaro.org>
On Thu, Jun 01, 2023 at 07:03:41PM +0200, Krzysztof Kozlowski wrote:
> On 31/05/2023 01:06, Kees Cook wrote:
> > On Tue, 23 May 2023 02:20:23 +0000, Azeem Shaikh wrote:
> >> strlcpy() reads the entire source buffer first.
> >> This read may exceed the destination size limit.
> >> This is both inefficient and can lead to linear read
> >> overflows if a source string is not NUL-terminated [1].
> >> In an effort to remove strlcpy() completely [2], replace
> >> strlcpy() here with strscpy().
> >> No return values were used, so direct replacement is safe.
> >>
> >> [...]
> >
> > Applied to for-next/hardening, thanks!
> >
> > [1/1] w1: sgi_w1: Replace all non-returning strlcpy with strscpy
> > https://git.kernel.org/kees/c/4e4424b20cc4
>
> Please drop. This was already fixed and is in linux-next since almost a
> month:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git/commit/?h=for-next&id=5dfd3c73ff81618fee0ef682b6fd7779863f41e4
Thanks! Dropped.
--
Kees Cook
next prev parent reply other threads:[~2023-06-01 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 2:20 Azeem Shaikh
2023-05-23 17:22 ` Kees Cook
2023-05-30 23:06 ` Kees Cook
2023-06-01 17:03 ` Krzysztof Kozlowski
2023-06-01 18:25 ` Kees Cook [this message]
2023-06-01 17:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306011125.D66A54586E@keescook \
--to=keescook@chromium.org \
--cc=azeemshaikh38@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®