From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCF0C77B7E for ; Thu, 1 Jun 2023 22:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232124AbjFAWPz (ORCPT ); Thu, 1 Jun 2023 18:15:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbjFAWPp (ORCPT ); Thu, 1 Jun 2023 18:15:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 281B7E4D; Thu, 1 Jun 2023 15:15:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C75D063772; Thu, 1 Jun 2023 22:15:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4685C433EF; Thu, 1 Jun 2023 22:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1685657701; bh=Mz2D+VquIEbQurDxx66CaTe238DU4WUo7qh0rtC9tQ8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QehpPFezV3kqBz6wJ/s9stmno57cE6bHg9H6rg+LKSa7GKj2+WqijaS7ew6x5NSxi N7XLi8kVsQtDhGUtE2LD5QA8aRKG+tl9OLM48b2tAr7NxHm5PSo7vzsXLZNofSC6ZA 3YaYFclotXT6IVfZQ9ZTTQng2OYhkItNl/41/M4w= Date: Thu, 1 Jun 2023 15:15:00 -0700 From: Andrew Morton To: Kees Cook Cc: Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Joe Perches , "Gustavo A . R . Silva" , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v5] checkpatch: Check for 0-length and 1-element arrays Message-Id: <20230601151500.b9937b28946c38ef186c1ce5@linux-foundation.org> In-Reply-To: <20230601160746.up.948-kees@kernel.org> References: <20230601160746.up.948-kees@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jun 2023 09:07:46 -0700 Kees Cook wrote: > Fake flexible arrays have been deprecated since last millennium. Proper > C99 flexible arrays must be used throughout the kernel so > CONFIG_FORTIFY_SOURCE and CONFIG_UBSAN_BOUNDS can provide proper array > bounds checking. > > Cc: Andy Whitcroft > Cc: Dwaipayan Ray > Cc: Lukas Bulwahn > Fixed-by: Joe Perches You didn't checkpatch your checkpatch patch! WARNING: Non-standard signature: Fixed-by: #248: Fixed-by: Joe Perches I'll do my usual [joe@perches.com: handle __packed for srtucts]