From: Christian Brauner <brauner@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Christian Brauner <brauner@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
jfs-discussion@lists.sourceforge.net,
"Dr. David Alan Gilbert" <linux@treblig.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
Dave Kleikamp <shaggy@kernel.org>
Subject: Re: [PATCH] jfs: Use unsigned variable for length calculations
Date: Fri, 2 Jun 2023 10:32:20 +0200 [thread overview]
Message-ID: <20230602-unnahbar-halbmarathon-22e48883e051@brauner> (raw)
In-Reply-To: <20230204183355.never.877-kees@kernel.org>
On Sat, 04 Feb 2023 10:33:56 -0800, Kees Cook wrote:
> To avoid confusing the compiler about possible negative sizes, switch
> "ssize" which can never be negative from int to u32. Seen with GCC 13:
>
> ../fs/jfs/namei.c: In function 'jfs_symlink': ../include/linux/fortify-string.h:57:33: warning: '__builtin_memcpy' pointer overflow between offset 0 and size [-2147483648, -1]
> [-Warray-bounds=]
> 57 | #define __underlying_memcpy __builtin_memcpy
> | ^
> ...
> ../fs/jfs/namei.c:950:17: note: in expansion of macro 'memcpy'
> 950 | memcpy(ip->i_link, name, ssize);
> | ^~~~~~
>
> [...]
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/1] jfs: Use unsigned variable for length calculations
https://git.kernel.org/vfs/vfs/c/2d6e1895d440
next prev parent reply other threads:[~2023-06-02 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 18:33 Kees Cook
2023-02-04 20:25 ` Dr. David Alan Gilbert
2023-02-06 18:35 ` Kees Cook
2023-02-06 19:50 ` Dr. David Alan Gilbert
2023-06-01 16:55 ` Kees Cook
2023-06-02 5:28 ` Jeff Xu
2023-06-05 13:24 ` David Laight
2023-06-02 8:32 ` Christian Brauner [this message]
2023-06-02 13:37 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602-unnahbar-halbmarathon-22e48883e051@brauner \
--to=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®