From: Zhangjin Wu <falcon@tinylab.org>
To: falcon@tinylab.org, thomas@t-8ch.de, w@1wt.eu
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH] selftests/nolibc: test_fork: fix up duplicated print
Date: Fri, 2 Jun 2023 10:41:57 +0800 [thread overview]
Message-ID: <20230602024157.11151-1-falcon@tinylab.org> (raw)
In-Reply-To: <61bdfe7bacebdef8aa9195f6f2550a5b0d33aab3.1685426545.git.falcon@tinylab.org>
Hi, Willy
What about this one for 2023xxxx-nolibc-rv32+stkp6?
@Thomas, welcome your Reviewed-by If it is ok for you ;-)
Best regards,
Zhangjin
> running nolibc-test with glibc on x86_64 got such print issue:
>
> 29 execve_root = -1 EACCES [OK]
> 30 fork30 fork = 0 [OK]
> 31 getdents64_root = 712 [OK]
>
> The fork test case has three printf calls:
>
> (1) llen += printf("%d %s", test, #name);
> (2) llen += printf(" = %d %s ", expr, errorname(errno));
> (3) llen += pad_spc(llen, 64, "[FAIL]\n"); --> vfprintf()
>
> In the following scene, the above issue happens:
>
> (a) The parent calls (1)
> (b) The parent calls fork()
> (c) The child runs and shares the print buffer of (1)
> (d) The child exits, flushs the print buffer and closes its own stdout/stderr
> * "30 fork" is printed at the first time.
> (e) The parent calls (2) and (3), with "\n" in (3), it flushs the whole buffer
> * "30 fork = 0 ..." is printed
>
> Therefore, there are two "30 fork" in the stdout.
>
> Between (a) and (b), if flush the stdout (and the sterr), the child in
> stage (c) will not be able to 'see' the print buffer.
>
> Signed-off-by: Zhangjin Wu <falcon@tinylab.org>
> ---
> tools/testing/selftests/nolibc/nolibc-test.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index 7de46305f419..88323a60aa4a 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -486,7 +486,13 @@ static int test_getpagesize(void)
> static int test_fork(void)
> {
> int status;
> - pid_t pid = fork();
> + pid_t pid;
> +
> + /* flush the printf buffer to avoid child flush it */
> + fflush(stdout);
> + fflush(stderr);
> +
> + pid = fork();
>
> switch (pid) {
> case -1:
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2023-06-02 2:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 6:03 Zhangjin Wu
2023-06-02 2:41 ` Zhangjin Wu [this message]
2023-06-02 10:20 ` Thomas Weißschuh
2023-06-04 10:47 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602024157.11151-1-falcon@tinylab.org \
--to=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=thomas@t-8ch.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®