From: Borislav Petkov <bp@alien8.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Sean Christopherson <seanjc@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joerg Roedel <jroedel@suse.de>, Andi Kleen <ak@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Tom Lendacky <thomas.lendacky@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Dario Faggioli <dfaggioli@suse.com>,
Mike Rapoport <rppt@kernel.org>,
David Hildenbrand <david@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
marcelo.cerri@canonical.com, tim.gardner@canonical.com,
khalid.elmously@canonical.com, philip.cox@canonical.com,
aarcange@redhat.com, peterx@redhat.com, x86@kernel.org,
linux-mm@kvack.org, linux-coco@lists.linux.dev,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Liam Merwick <liam.merwick@oracle.com>
Subject: Re: [PATCHv13 4/9] x86/boot/compressed: Handle unaccepted memory
Date: Fri, 2 Jun 2023 18:45:33 +0200 [thread overview]
Message-ID: <20230602164533.GHZHocre9bsQsU5L4+@fat_crate.local> (raw)
In-Reply-To: <CAMj1kXENJ6VJMDtVmKqozRb6NMU7Y-fhYJWiCbRd2aQ_tmXHMg@mail.gmail.com>
On Fri, Jun 02, 2023 at 06:17:13PM +0200, Ard Biesheuvel wrote:
> 'EFI code' is ambiguous here.
>
> Most of the decompressor code is constructed in a way that permits
> - booting 'native EFI' via the EFI stub
> - booting 'pseudo-EFI' where GRUB or another Linux/x86 specific
> bootloader populates boot_params with all the EFI specific information
> (system table, memory map, etc)
>
> This distinction has been abstracted away here, and so we might be
> dealing with the second case, and booting from a GRUB that does not
> understand accepted memory, but simply copied the EFI memory map
> (including unaccepted regions) as it normally does. (Note that the
> second case also covers kexec boot, so we do need to support it)
Right, I was hoping there to be some glue which sanity-checks
boot_params.efi_info instead relying on users to do so and thus have
a bunch of duplicated code.
So, yes, right after populating the boot_params pointer...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-06-02 16:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 18:25 [PATCHv13 0/9] mm, x86/cc, efi: Implement support for " Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 1/9] mm: Add " Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 2/9] efi/x86: Get full memory map in allocate_e820() Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 3/9] efi/libstub: Implement support for unaccepted memory Kirill A. Shutemov
2023-06-02 12:10 ` Borislav Petkov
2023-06-02 12:20 ` Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 4/9] x86/boot/compressed: Handle " Kirill A. Shutemov
2023-06-02 14:06 ` Borislav Petkov
2023-06-02 15:36 ` Kirill A. Shutemov
2023-06-02 15:59 ` Ard Biesheuvel
2023-06-02 16:10 ` Borislav Petkov
2023-06-02 16:09 ` Borislav Petkov
2023-06-02 16:17 ` Ard Biesheuvel
2023-06-02 16:45 ` Borislav Petkov [this message]
2023-06-05 11:29 ` Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 5/9] efi: Add unaccepted memory support Kirill A. Shutemov
2023-06-05 15:43 ` Borislav Petkov
2023-06-05 17:33 ` Kirill A. Shutemov
2023-06-05 19:12 ` Borislav Petkov
2023-06-05 21:37 ` Kirill A. Shutemov
2023-06-06 12:19 ` Kirill A. Shutemov
2023-06-06 12:29 ` Borislav Petkov
2023-06-01 18:25 ` [PATCHv13 6/9] efi/unaccepted: Avoid load_unaligned_zeropad() stepping into unaccepted memory Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 7/9] x86/tdx: Make _tdx_hypercall() and __tdx_module_call() available in boot stub Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 8/9] x86/tdx: Refactor try_accept_one() Kirill A. Shutemov
2023-06-01 18:25 ` [PATCHv13 9/9] x86/tdx: Add unaccepted memory support Kirill A. Shutemov
2023-06-02 13:22 ` Tom Lendacky
2023-06-02 14:26 ` Tom Lendacky
2023-06-05 19:18 ` Dave Hansen
2023-06-05 21:39 ` Kirill A. Shutemov
2023-06-02 14:35 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602164533.GHZHocre9bsQsU5L4+@fat_crate.local \
--to=bp@alien8.de \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=dfaggioli@suse.com \
--cc=jroedel@suse.de \
--cc=khalid.elmously@canonical.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=liam.merwick@oracle.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=philip.cox@canonical.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.gardner@canonical.com \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®