From: Johannes Weiner <hannes@cmpxchg.org>
To: Domenico Cerasuolo <cerasuolodomenico@gmail.com>
Cc: vitaly.wool@konsulko.com, minchan@kernel.org,
senozhatsky@chromium.org, yosryahmed@google.com,
linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com,
nphamcs@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [RFC PATCH 4/7] mm: zswap: remove page reclaim logic from zsmalloc
Date: Mon, 5 Jun 2023 11:37:18 -0400 [thread overview]
Message-ID: <20230605153718.GB221380@cmpxchg.org> (raw)
In-Reply-To: <20230605085419.44383-5-cerasuolodomenico@gmail.com>
On Mon, Jun 05, 2023 at 10:54:16AM +0200, Domenico Cerasuolo wrote:
> @@ -884,14 +842,6 @@ static inline bool obj_allocated(struct page *page, void *obj, unsigned long *ph
> return obj_tagged(page, obj, phandle, OBJ_ALLOCATED_TAG);
> }
>
> -#ifdef CONFIG_ZPOOL
> -static bool obj_stores_deferred_handle(struct page *page, void *obj,
> - unsigned long *phandle)
> -{
> - return obj_tagged(page, obj, phandle, OBJ_DEFERRED_HANDLE_TAG);
> -}
> -#endif
You can actually remove even more here.
The entire concept of deferred_handle is about serializing free with
reclaim. It can all go: OBJ_DEFERRED_HANDLE_TAG, the member in struct
link_free, this function here, find_deferred_handle_obj() (declaration
and implementation), free_handles(), and the deferred handle bits in
obj_free() including the handle parameter itself.
next prev parent reply other threads:[~2023-06-05 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 8:54 [PATCH 0/7] mm: zswap: move writeback LRU from zpool to zswap Domenico Cerasuolo
2023-06-05 8:54 ` [RFC PATCH 1/7] mm: zswap: add pool shrinking mechanism Domenico Cerasuolo
2023-06-05 15:29 ` Johannes Weiner
2023-06-06 9:31 ` Domenico Cerasuolo
2023-06-06 2:18 ` Yosry Ahmed
2023-06-06 9:35 ` Domenico Cerasuolo
2023-06-05 8:54 ` [RFC PATCH 2/7] mm: zswap: remove page reclaim logic from zbud Domenico Cerasuolo
2023-06-05 8:54 ` [RFC PATCH 3/7] mm: zswap: remove page reclaim logic from z3fold Domenico Cerasuolo
2023-06-05 8:54 ` [RFC PATCH 4/7] mm: zswap: remove page reclaim logic from zsmalloc Domenico Cerasuolo
2023-06-05 15:37 ` Johannes Weiner [this message]
2023-06-05 23:21 ` Nhat Pham
2023-06-05 23:37 ` Nhat Pham
2023-06-06 9:47 ` Domenico Cerasuolo
2023-06-05 8:54 ` [RFC PATCH 5/7] mm: zswap: remove shrink from zpool interface Domenico Cerasuolo
2023-06-05 8:54 ` [RFC PATCH 6/7] mm: zswap: simplify writeback function Domenico Cerasuolo
2023-06-05 15:44 ` Johannes Weiner
2023-06-05 8:54 ` [RFC PATCH 7/7] mm: zswap: remove zswap_header Domenico Cerasuolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605153718.GB221380@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=ddstreet@ieee.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®