From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0CEC77B73 for ; Tue, 6 Jun 2023 15:35:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237786AbjFFPfj (ORCPT ); Tue, 6 Jun 2023 11:35:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233755AbjFFPfg (ORCPT ); Tue, 6 Jun 2023 11:35:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39E74E7E for ; Tue, 6 Jun 2023 08:35:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0A9B63517 for ; Tue, 6 Jun 2023 15:35:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6DBBC433D2; Tue, 6 Jun 2023 15:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686065734; bh=Xt4audZ365Q+PvUv6uNxy2e/yIbqQ28OmbVNfLY4CKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XhNyr11CmQawhEhlHUx6nQMF29fI9ghKpUoFa2oDTUfY710tgzYk6Jwjvl64G/tDI yMnd7Cwk1FNic9l+wO1mxHnW8bioxqlAWLEXHZWFSovLzW88CrrjlWX6o0WVriC7qF HcycoIyk2rDpPXP7X/ltVVilykY/KsGVD5K1CjvmJD83nHZSBFBak89AA4qBgYsIIA D7py/B4/U4ETH9BhM4NdZ2y6xT6nom8LWvv4T+1cSTWte224TlUeU2QXg7R7ph9V4n 9ILlUgN5vHsGBoqpHcKJiOpY6D1VQ6Snm0sE1/KFdknH4rFAD0/JETsrf0zz+0Zx2o qSLmbZ9YwkBjA== Date: Tue, 6 Jun 2023 16:35:29 +0100 From: Conor Dooley To: Sunil V L Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Anup Patel , Will Deacon , Mark Rutland , kernel test robot Subject: Re: [PATCH v1 -next 1/2] RISC-V: ACPI : Fix for usage of pointers in different address space Message-ID: <20230606-conduit-cupped-1791a640713b@spud> References: <20230605143512.707533-1-sunilvl@ventanamicro.com> <20230605143512.707533-2-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HLHcBDvaBo7VA5cu" Content-Disposition: inline In-Reply-To: <20230605143512.707533-2-sunilvl@ventanamicro.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HLHcBDvaBo7VA5cu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Sunil, On Mon, Jun 05, 2023 at 08:05:11PM +0530, Sunil V L wrote: > The arch specific __acpi_map_table can be wrapper around either > early_memremap or early_ioremap. But early_memremap > routine works with normal pointers whereas __acpi_map_table expects > pointers in iomem address space. This causes kernel test bot to fail > while using the sparse tool. Fix the issue by using early_ioremap and > similar fix done for __acpi_unmap_table. >=20 > Signed-off-by: Sunil V L > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202305201427.I7QhPjNW-lkp@i= ntel.com/ Is this Fixes: a91a9ffbd3a5 ("RISC-V: Add support to build the ACPI core") ? Otherwise, Reviewed-by: Conor Dooley Thanks, Conor. > --- > arch/riscv/kernel/acpi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/riscv/kernel/acpi.c b/arch/riscv/kernel/acpi.c > index df5a45a2eb93..5ee03ebab80e 100644 > --- a/arch/riscv/kernel/acpi.c > +++ b/arch/riscv/kernel/acpi.c > @@ -204,7 +204,7 @@ void __init __iomem *__acpi_map_table(unsigned long p= hys, unsigned long size) > if (!size) > return NULL; > =20 > - return early_memremap(phys, size); > + return early_ioremap(phys, size); > } > =20 > void __init __acpi_unmap_table(void __iomem *map, unsigned long size) > @@ -212,7 +212,7 @@ void __init __acpi_unmap_table(void __iomem *map, uns= igned long size) > if (!map || !size) > return; > =20 > - early_memunmap(map, size); > + early_iounmap(map, size); > } > =20 > void *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) > --=20 > 2.34.1 >=20 --HLHcBDvaBo7VA5cu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZH9SQQAKCRB4tDGHoIJi 0hZTAQDzgYgjwG/DSfMNyBQuzsY/PvRtR+1BBA2sQdrN9IKUQQEAgKPZEeWa6ykw OcKB1bLk8MSPeMYY+K3Qn7D0stu5UQs= =JNG7 -----END PGP SIGNATURE----- --HLHcBDvaBo7VA5cu--