From: Christian Brauner <brauner@kernel.org>
To: Siddh Raman Pant <code@siddh.me>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
David Disseldorp <ddiss@suse.de>,
Nick Alcock <nick.alcock@oracle.com>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v5] kernel/watch_queue: NULL the dangling *pipe, and use it for clear check
Date: Tue, 6 Jun 2023 10:52:49 +0200 [thread overview]
Message-ID: <20230606-getaucht-groschen-b2f1be714351@brauner> (raw)
In-Reply-To: <20230605143616.640517-1-code@siddh.me>
On Mon, 05 Jun 2023 20:06:16 +0530, Siddh Raman Pant wrote:
> NULL the dangling pipe reference while clearing watch_queue.
>
> If not done, a reference to a freed pipe remains in the watch_queue,
> as this function is called before freeing a pipe in free_pipe_info()
> (see line 834 of fs/pipe.c).
>
> The sole use of wqueue->defunct is for checking if the watch queue has
> been cleared, but wqueue->pipe is also NULLed while clearing.
>
> [...]
Massaged the commit message a bit and applied David's Ack as requested.
---
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/1] kernel/watch_queue: NULL the dangling *pipe, and use it for clear check
https://git.kernel.org/vfs/vfs/c/ae33d3de5ff5
next prev parent reply other threads:[~2023-06-06 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 14:36 Siddh Raman Pant
2023-06-06 8:52 ` Christian Brauner [this message]
2023-06-06 9:08 ` Siddh Raman Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606-getaucht-groschen-b2f1be714351@brauner \
--to=brauner@kernel.org \
--cc=code@siddh.me \
--cc=corbet@lwn.net \
--cc=ddiss@suse.de \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®