mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: dave.hansen@intel.com, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de
Cc: decui@microsoft.com, rick.p.edgecombe@intel.com,
	sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
	thomas.lendacky@amd.com, x86@kernel.org,
	linux-kernel@vger.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv3 3/3] x86/mm: Fix enc_status_change_finish_noop()
Date: Tue,  6 Jun 2023 12:56:22 +0300	[thread overview]
Message-ID: <20230606095622.1939-4-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <20230606095622.1939-1-kirill.shutemov@linux.intel.com>

enc_status_change_finish_noop() is now defined as always-fail, which
doesn't make sense for noop.

The change has no user-visible effect because it is only called if the
platform has CC_ATTR_MEM_ENCRYPT. All platforms with the attribute
override the callback with their own implementation.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 arch/x86/kernel/x86_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c
index f230d4d7d8eb..64664311ac2b 100644
--- a/arch/x86/kernel/x86_init.c
+++ b/arch/x86/kernel/x86_init.c
@@ -131,7 +131,7 @@ struct x86_cpuinit_ops x86_cpuinit = {
 static void default_nmi_init(void) { };
 
 static bool enc_status_change_prepare_noop(unsigned long vaddr, int npages, bool enc) { return true; }
-static bool enc_status_change_finish_noop(unsigned long vaddr, int npages, bool enc) { return false; }
+static bool enc_status_change_finish_noop(unsigned long vaddr, int npages, bool enc) { return true; }
 static bool enc_tlb_flush_required_noop(bool enc) { return false; }
 static bool enc_cache_flush_required_noop(void) { return false; }
 static bool is_private_mmio_noop(u64 addr) {return false; }
-- 
2.39.3


  parent reply	other threads:[~2023-06-06  9:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06  9:56 [PATCHv3 0/3] x86/tdx: Fix one more load_unaligned_zeropad() issue Kirill A. Shutemov
2023-06-06  9:56 ` [PATCHv3 1/3] x86/mm: Allow guest.enc_status_change_prepare() to fail Kirill A. Shutemov
2023-06-06  9:56 ` [PATCHv3 2/3] x86/tdx: Fix race between set_memory_encrypted() and load_unaligned_zeropad() Kirill A. Shutemov
2023-06-06 18:14   ` Dave Hansen
2023-06-06 18:37     ` Kirill A. Shutemov
2023-06-06 23:29       ` Dave Hansen
2023-06-07 11:16         ` Kirill A. Shutemov
2023-06-06  9:56 ` Kirill A. Shutemov [this message]
2023-07-06 16:48 ` [PATCHv3 0/3] x86/tdx: Fix one more load_unaligned_zeropad() issue Michael Kelley (LINUX)
2023-07-06 17:45   ` Dave Hansen
2023-07-07 14:06   ` Kirill A. Shutemov
2023-07-08 23:53     ` Michael Kelley (LINUX)
2023-07-09  6:09       ` Kirill A. Shutemov
2023-07-10 13:59         ` Tom Lendacky
2023-07-10 14:17           ` Michael Kelley (LINUX)
2023-07-13 14:43         ` Michael Kelley (LINUX)
2023-07-24 23:19           ` Kirill A. Shutemov
2023-07-25 15:51             ` Michael Kelley (LINUX)
2023-07-25 23:12               ` Kirill A. Shutemov
2023-07-26  3:15                 ` Michael Kelley (LINUX)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230606095622.1939-4-kirill.shutemov@linux.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=decui@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®