Re: [PATCH RFC v2 1/6] media: v4l2-ctrls: fix documentation of V4L2_CID_FOCUS_ABSOLUTE unit

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Michael,

Thank you for the patch.

On Tue, Apr 25, 2023 at 11:45:11AM +0200, Michael Riesch wrote:
> The current unit description of the V4L2_CID_FOCUS_ABSOLUTE does not
> make sense and was probably copy-pasted from V4L2_CID_FOCUS_RELATIVE.
> Fix the unit description in the documentation.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
>  Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
> index daa4f40869f8..df29150dce7b 100644
> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
> @@ -140,8 +140,8 @@ enum v4l2_exposure_metering -
>  
>  ``V4L2_CID_FOCUS_ABSOLUTE (integer)``
>      This control sets the focal point of the camera to the specified
> -    position. The unit is undefined. Positive values set the focus
> -    closer to the camera, negative values towards infinity.
> +    position. The unit is undefined. Larger values move the focus closer to
> +    the camera, smaller values move the focus to infinity.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  
>  ``V4L2_CID_FOCUS_RELATIVE (integer)``
>      This control moves the focal point of the camera by the specified
> 

-- 
Regards,

Laurent Pinchart