From: James Liu <james.liu@hpe.com>
To: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: hpelk@lists.osp.hpe.com, james.liu@hpe.com
Subject: [PATCH v1] ACPI: reboot: Increase the delay to avoid racing after writing to ACPI RESET_REG on AMD Milan platforms.
Date: Wed, 7 Jun 2023 11:44:03 +0800 [thread overview]
Message-ID: <20230607034403.2885-1-james.liu@hpe.com> (raw)
For AMD Milan platforms, the delay of 15ms is insufficient to avoid racing
of reboot mechanisms. That said, the AMD Milan processors don't reboot
in 15ms after invoking acpi_reset().
The proposed 50ms delay can effectively work around this issue.
This extended delay aligns better with ACPI v6.4 (i.e., sec. 4.8.4.6),
which indicates that ideally OSPM should execute spin loops on the CPUs
in the system following a write to this register.
Signed-off-by: James Liu <james.liu@hpe.com>
---
drivers/acpi/reboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
index b79b7c99c237..002f7c7814a1 100644
--- a/drivers/acpi/reboot.c
+++ b/drivers/acpi/reboot.c
@@ -78,5 +78,5 @@ void acpi_reboot(void)
* The 15ms delay has been found to be long enough for the system
* to reboot on the affected platforms.
*/
- mdelay(15);
+ mdelay(50);
}
--
2.40.1
next reply other threads:[~2023-06-07 3:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 3:44 James Liu [this message]
2023-06-07 11:19 ` Rafael J. Wysocki
2023-06-08 9:14 ` James Liu
2023-06-12 16:57 ` Rafael J. Wysocki
[not found] ` <64dbd730.050a0220.46601.d780SMTPIN_ADDED_BROKEN@mx.google.com>
2023-08-17 11:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607034403.2885-1-james.liu@hpe.com \
--to=james.liu@hpe.com \
--cc=hpelk@lists.osp.hpe.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®