From: Yangtao Li <frank.li@vivo.com>
To: jaegeuk@kernel.org
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH v2] f2fs_io: expend fallocate command
Date: Wed, 7 Jun 2023 22:56:36 +0800 [thread overview]
Message-ID: <20230607145637.14769-1-frank.li@vivo.com> (raw)
Expend fallocate command to support more flags.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
tools/f2fs_io/f2fs_io.c | 39 +++++++++++++++++++++++++++++++++------
1 file changed, 33 insertions(+), 6 deletions(-)
diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
index 1774eca..5a6a6a0 100644
--- a/tools/f2fs_io/f2fs_io.c
+++ b/tools/f2fs_io/f2fs_io.c
@@ -413,9 +413,13 @@ static void do_pinfile(int argc, char **argv, const struct cmd_desc *cmd)
#define fallocate_desc "fallocate"
#define fallocate_help \
-"f2fs_io fallocate [keep_size] [offset] [length] [file]\n\n" \
+"f2fs_io fallocate [-cipz] [keep_size] [offset] [length] [file]\n\n" \
"fallocate given the file\n" \
" [keep_size] : 1 or 0\n" \
+" -p : punch hole\n" \
+" -c : collapse range\n" \
+" -z : zero range\n" \
+" -i : insert range\n" \
static void do_fallocate(int argc, char **argv, const struct cmd_desc *cmd)
{
@@ -423,20 +427,43 @@ static void do_fallocate(int argc, char **argv, const struct cmd_desc *cmd)
off_t offset, length;
struct stat sb;
int mode = 0;
+ int c;
- if (argc != 5) {
+ while ((c = getopt(argc, argv, "cipz")) != -1) {
+ switch (c) {
+ case 'c':
+ mode |= FALLOC_FL_COLLAPSE_RANGE;
+ break;
+ case 'i':
+ mode |= FALLOC_FL_INSERT_RANGE;
+ break;
+ case 'p':
+ mode |= FALLOC_FL_PUNCH_HOLE;
+ break;
+ case 'z':
+ mode |= FALLOC_FL_ZERO_RANGE;
+ break;
+ default:
+ fputs(cmd->cmd_help, stderr);
+ exit(2);
+ }
+ }
+ argc -= optind;
+ argv += optind;
+
+ if (argc != 4) {
fputs("Excess arguments\n\n", stderr);
fputs(cmd->cmd_help, stderr);
exit(1);
}
- if (!strcmp(argv[1], "1"))
+ if (!strcmp(argv[0], "1"))
mode |= FALLOC_FL_KEEP_SIZE;
- offset = atoi(argv[2]);
- length = atoll(argv[3]);
+ offset = atoi(argv[1]);
+ length = atoll(argv[2]);
- fd = xopen(argv[4], O_RDWR, 0);
+ fd = xopen(argv[3], O_RDWR, 0);
if (fallocate(fd, mode, offset, length) != 0)
die_errno("fallocate failed");
--
2.39.0
next reply other threads:[~2023-06-07 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 14:56 Yangtao Li [this message]
2023-06-08 1:56 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607145637.14769-1-frank.li@vivo.com \
--to=frank.li@vivo.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®