mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: nikhil.agarwal@amd.com, Nipun.Gupta@amd.com,
	geert@linux-m68k.org, linux-kernel@vger.kernel.org, git@amd.com,
	michal.simek@amd.com
Subject: Re: [PATCH v3] cdx: Rename MCDI_LOGGING to CDX_MCDI_LOGGING
Date: Wed, 7 Jun 2023 12:01:25 +0200	[thread overview]
Message-ID: <2023060735-unwoven-sip-df79@gregkh> (raw)
In-Reply-To: <20230606140137.1216731-1-abhijit.gangurde@amd.com>

On Tue, Jun 06, 2023 at 07:31:37PM +0530, Abhijit Gangurde wrote:
> MCDI_LOGGING is too generic considering other MCDI users
> SFC_MCDI_LOGGING and SFC_SIENA_MCDI_LOGGING. Rename it to
> CDX_MCDI_LOGGING makes it more domain specific.
> 
> Also, move CONFIG_CDX_MCDI_LOGGING to header file.
> 
> Fixes: eb96b740192b ("cdx: add MCDI protocol interface for firmware interaction")
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Closes: https://lore.kernel.org/lkml/CAMuHMdWTCdQagFFANygMgA8D0sWaoGxWv2AjibC3vwSd0UxuRw@mail.gmail.com/
> ---
>  Changes v2->v3:
>  - Dropped sysfs entry changes from v2

Where is patch 2/2 in this series that moves to use dynamic debugging
instead of this custom mess?

This shouln't be a config option at all, as no one will be able to
enable it on a real system.

thanks,

greg k-h

  reply	other threads:[~2023-06-07 10:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 14:01 Abhijit Gangurde
2023-06-07 10:01 ` Greg KH [this message]
2023-06-12  8:10   ` Gangurde, Abhijit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023060735-unwoven-sip-df79@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Nipun.Gupta@amd.com \
    --cc=abhijit.gangurde@amd.com \
    --cc=geert@linux-m68k.org \
    --cc=git@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=nikhil.agarwal@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®