From: Christian Brauner <brauner@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-kernel@vger.kernel.org, gehao@kylinos.cn,
Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kbingham@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pankaj Raghav <p.raghav@samsung.com>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] scripts/gdb: Fix SB_* constants parsing
Date: Thu, 8 Jun 2023 09:31:02 +0200 [thread overview]
Message-ID: <20230608-sinkt-melodie-5816a03405de@brauner> (raw)
In-Reply-To: <20230607221337.2781730-1-florian.fainelli@broadcom.com>
On Wed, Jun 07, 2023 at 03:13:35PM -0700, Florian Fainelli wrote:
> After f15afbd34d8f ("fs: fix undefined behavior in bit shift for
> SB_NOUSER") the constants were changed from plain integers which
> LX_VALUE() can parse to constants using the BIT() macro which causes the
> following:
>
> Reading symbols from build/linux-custom/vmlinux...done.
> Traceback (most recent call last):
> File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/vmlinux-gdb.py", line 25, in <module>
> import linux.constants
> File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/scripts/gdb/linux/constants.py", line 5
> LX_SB_RDONLY = ((((1UL))) << (0))
>
> Use LX_GDBPARSED() which does not suffer from that issue.
>
> f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUSER")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
Fine by me,
Acked-by: Christian Brauner <brauner@kernel.org>
prev parent reply other threads:[~2023-06-08 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 22:13 Florian Fainelli
2023-06-08 7:31 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608-sinkt-melodie-5816a03405de@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=florian.fainelli@broadcom.com \
--cc=gehao@kylinos.cn \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®