mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maninder Singh <maninder1.s@samsung.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: "ast@kernel.org" <ast@kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
	"andrii@kernel.org" <andrii@kernel.org>,
	"martin.lau@linux.dev" <martin.lau@linux.dev>,
	"song@kernel.org" <song@kernel.org>, "yhs@fb.com" <yhs@fb.com>,
	"kpsingh@kernel.org" <kpsingh@kernel.org>,
	"sdf@google.com" <sdf@google.com>,
	"haoluo@google.com" <haoluo@google.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>,
	"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
	"vincenzopalazzodev@gmail.com" <vincenzopalazzodev@gmail.com>,
	"ojeda@kernel.org" <ojeda@kernel.org>,
	"jgross@suse.com" <jgross@suse.com>,
	"brauner@kernel.org" <brauner@kernel.org>,
	"michael.christie@oracle.com" <michael.christie@oracle.com>,
	"samitolvanen@google.com" <samitolvanen@google.com>,
	"glider@google.com" <glider@google.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"stephen.s.brennan@oracle.com" <stephen.s.brennan@oracle.com>,
	"alan.maguire@oracle.com" <alan.maguire@oracle.com>,
	"pmladek@suse.com" <pmladek@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	Onkarnath <onkarnath.1@samsung.com>
Subject: RE: [PATCH v4 2/3] bpf: make bpf_dump_raw_ok() based on CONFIG_KALLSYMS
Date: Thu, 08 Jun 2023 08:40:11 +0530	[thread overview]
Message-ID: <20230608031011epcms5p23c6aa244e514729b98df2af7e45db67c@epcms5p2> (raw)
In-Reply-To: <CAEf4Bzb4B9FxMnf3t81D22FWkciLOvwDPLY0BbEPGGe7R5QPrg@mail.gmail.com>

Hi,

> > also as per below code:
> > (we were not sure whether BPF will work or not with patch 3/3 because of no expertise on BPF code,
> > so we keep the behaviour same)
> 
> I think bpf_dump_raw_ok() is purely about checking whether it's ok to
> return unobfuscated kernel addresses to user/BPF program. So it feels
> like it should be ok to just rely on kallsyms_show_value() and not
> special case here. If some of the code relies on actually having
> CONFIG_KALLSYMS and related functionality, it should be properly
> guarded already (or should enforce `SELECT KALLSYMS` in Kconfig).

Thanks for your confirmation, I will resend patches without bpf change.

Thanks,
Maninder Singh

  parent reply	other threads:[~2023-06-08  3:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230606042812epcas5p262df978931619b2d62e493d08147e120@epcas5p2.samsung.com>
2023-06-06  4:28 ` [PATCH v4 1/3] kallsyms: move kallsyms_show_value() out of kallsyms.c Maninder Singh
     [not found]   ` <CGME20230606042819epcas5p4f0601efb42d59007cba023c73fa0624a@epcas5p4.samsung.com>
2023-06-06  4:28     ` [PATCH v4 2/3] bpf: make bpf_dump_raw_ok() based on CONFIG_KALLSYMS Maninder Singh
2023-06-06 11:26       ` Leizhen (ThunderTown)
2023-06-06 17:08       ` Andrii Nakryiko
     [not found]       ` <CGME20230606042819epcas5p4f0601efb42d59007cba023c73fa0624a@epcms5p8>
2023-06-07  3:40         ` Maninder Singh
2023-06-07 22:19           ` Andrii Nakryiko
     [not found]           ` <CGME20230606042819epcas5p4f0601efb42d59007cba023c73fa0624a@epcms5p2>
2023-06-08  3:10             ` Maninder Singh [this message]
     [not found]   ` <CGME20230606042825epcas5p13579e5999f3cc7d9d517e4c3040cf16a@epcas5p1.samsung.com>
2023-06-06  4:28     ` [PATCH v4 3/3] kallsyms: make kallsyms_show_value() as generic function Maninder Singh
2023-06-06 11:27       ` Leizhen (ThunderTown)
2023-06-06 11:23   ` [PATCH v4 1/3] kallsyms: move kallsyms_show_value() out of kallsyms.c Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608031011epcms5p23c6aa244e514729b98df2af7e45db67c@epcms5p2 \
    --to=maninder1.s@samsung.com \
    --cc=alan.maguire@oracle.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=glider@google.com \
    --cc=haoluo@google.com \
    --cc=jgross@suse.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=keescook@chromium.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mcgrof@kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=ojeda@kernel.org \
    --cc=onkarnath.1@samsung.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=samitolvanen@google.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=vincenzopalazzodev@gmail.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®