From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D596C7EE29 for ; Thu, 8 Jun 2023 22:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235523AbjFHWvv (ORCPT ); Thu, 8 Jun 2023 18:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbjFHWvt (ORCPT ); Thu, 8 Jun 2023 18:51:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8539F2D59 for ; Thu, 8 Jun 2023 15:51:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05C1565171 for ; Thu, 8 Jun 2023 22:51:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98BA2C433D2; Thu, 8 Jun 2023 22:51:45 +0000 (UTC) Date: Thu, 8 Jun 2023 18:51:42 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Jiri Olsa , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Andrii Nakryiko , netdev@vger.kernel.org, bpf@vger.kernel.org, lkml , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" Subject: Re: [PATCH v12 bpf-next 02/12] fprobe: Add ftrace based probe APIs Message-ID: <20230608185142.7372e7b6@gandalf.local.home> In-Reply-To: <164735283857.1084943.1154436951479395551.stgit@devnote2> References: <164735281449.1084943.12438881786173547153.stgit@devnote2> <164735283857.1084943.1154436951479395551.stgit@devnote2> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Mar 2022 23:00:38 +0900 Masami Hiramatsu wrote: > +static void fprobe_init(struct fprobe *fp) > +{ > + fp->nmissed = 0; > + fp->ops.func = fprobe_handler; > + fp->ops.flags |= FTRACE_OPS_FL_SAVE_REGS; > +} > + Masami, I thought one of the advantages of fprobes over kprobes was that it did not need to use SAVE_REGS, as that causes more overhead than SAVE_ARGS? If fprobes uses save regs, what is the advantage of it over kprobes? -- Steve