From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 0/3] perf list: Improve libpfm4 event support
Date: Thu, 8 Jun 2023 16:23:57 -0700 [thread overview]
Message-ID: <20230608232400.3056312-1-namhyung@kernel.org> (raw)
Hello,
Ian and I found that some of libpfm4 events don't work well and it makes
confusing that perf list shows those unsupported events too. Let's check
if the event is supported like other events and skip if it's not.
Also add a new test for it. On my laptop, it runs ok like below:
$ ./perf test -v 102
102: perf all libpfm4 events test :
--- start ---
test child forked, pid 3039688
Testing ix86arch::UNHALTED_CORE_CYCLES
Testing ix86arch::INSTRUCTION_RETIRED
Testing ix86arch::UNHALTED_REFERENCE_CYCLES
Testing ix86arch::LLC_REFERENCES
Testing ix86arch::LLC_MISSES
Testing ix86arch::BRANCH_INSTRUCTIONS_RETIRED
Testing ix86arch::MISPREDICTED_BRANCH_RETIRED
Testing perf_raw::r0000
Testing icl::UNHALTED_CORE_CYCLES
Testing icl::UNHALTED_REFERENCE_CYCLES
Testing icl::INSTRUCTION_RETIRED
Testing INSTRUCTION_RETIRED
Testing icl::SQ_MISC
Testing icl::SQ_MISC:SQ_FULL
...
Testing icl::OCR:DEMAND_DATA_RD_L3_HIT_ANY
Testing icl::OCR:DEMAND_DATA_RD_L3_HIT_SNOOP_HITM
Testing icl::OCR:DEMAND_DATA_RD_L3_HIT_SNOOP_HIT_NO_FWD
Testing icl::OCR:DEMAND_DATA_RD_L3_HIT_SNOOP_MISS
Testing icl::OCR:DEMAND_DATA_RD_L3_HIT_SNOOP_NOT_NEEDED
test child finished with 0
---- end ----
perf all libpfm4 events test: Ok
Thanks,
Namhyung
Ian Rogers (2):
perf list: Check arguments to show libpfm4 events
perf test: Add test of libpfm4 events
Namhyung Kim (1):
perf list: Check if libpfm4 event is supported
tools/perf/builtin-list.c | 12 +++++-
tools/perf/tests/shell/stat_all_pfm.sh | 51 ++++++++++++++++++++++
tools/perf/util/pfm.c | 58 ++++++++++++++++++++++----
3 files changed, 112 insertions(+), 9 deletions(-)
create mode 100755 tools/perf/tests/shell/stat_all_pfm.sh
base-commit: 634c694de4cb2d050dc312ea43e0371d84c585a5
--
2.41.0.162.gfafddb0af9-goog
next reply other threads:[~2023-06-08 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 23:23 Namhyung Kim [this message]
2023-06-08 23:23 ` [PATCH 1/3] perf list: Check if libpfm4 event is supported Namhyung Kim
2023-06-08 23:38 ` Ian Rogers
2023-06-09 13:59 ` Arnaldo Carvalho de Melo
2023-06-08 23:23 ` [PATCH 2/3] perf list: Check arguments to show libpfm4 events Namhyung Kim
2023-06-08 23:24 ` [PATCH 3/3] perf test: Add test of " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608232400.3056312-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®