From: "Arınç ÜNAL" <arinc9.unal@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Russell King" <linux@armlinux.org.uk>
Cc: Landen Chao <landen.chao@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
Bartel Eerdekens <bartel.eerdekens@constell8.be>,
mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH net v2 4/7] net: dsa: mt7530: fix handling of BPDUs on MT7530 switch
Date: Sun, 11 Jun 2023 11:15:44 +0300 [thread overview]
Message-ID: <20230611081547.26747-4-arinc.unal@arinc9.com> (raw)
In-Reply-To: <20230611081547.26747-1-arinc.unal@arinc9.com>
BPDUs are link-local frames, therefore they must be trapped to the CPU
port. Currently, the MT7530 switch treats BPDUs as regular multicast
frames, therefore flooding them to user ports. To fix this, set BPDUs to be
trapped to the CPU port.
BPDUs received from a user port will be trapped to the numerically smallest
CPU port which is affine to the DSA conduit interface that is up.
Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
v2: Add this patch.
---
drivers/net/dsa/mt7530.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index df2626f72367..c2af23f2bc5d 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2259,6 +2259,10 @@ mt7530_setup(struct dsa_switch *ds)
priv->p6_interface = PHY_INTERFACE_MODE_NA;
+ /* Trap BPDUs to the CPU port */
+ mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK,
+ MT753X_BPDU_CPU_ONLY);
+
/* Enable and reset MIB counters */
mt7530_mib_reset(ds);
--
2.39.2
next prev parent reply other threads:[~2023-06-11 8:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 8:15 [PATCH net v2 1/7] net: dsa: mt7530: fix trapping frames with multiple CPU ports on MT7531 Arınç ÜNAL
2023-06-11 8:15 ` [PATCH net v2 2/7] net: dsa: mt7530: fix trapping frames with multiple CPU ports on MT7530 Arınç ÜNAL
2023-06-13 15:08 ` Vladimir Oltean
2023-06-13 17:14 ` Arınç ÜNAL
2023-06-13 17:18 ` Vladimir Oltean
2023-06-13 17:24 ` Vladimir Oltean
2023-06-13 17:30 ` Arınç ÜNAL
2023-06-13 17:39 ` Vladimir Oltean
2023-06-13 17:58 ` Arınç ÜNAL
2023-06-13 18:12 ` Jakub Kicinski
2023-06-13 19:03 ` Arınç ÜNAL
2023-06-13 19:09 ` Arınç ÜNAL
2023-06-13 20:29 ` Jakub Kicinski
2023-06-13 18:29 ` Russell King (Oracle)
2023-06-13 18:46 ` Arınç ÜNAL
2023-06-13 20:46 ` Vladimir Oltean
2023-06-13 20:18 ` Vladimir Oltean
2023-06-13 20:35 ` Arınç ÜNAL
2023-06-13 20:59 ` Vladimir Oltean
2023-06-13 21:04 ` Arınç ÜNAL
2023-06-13 21:14 ` Vladimir Oltean
2023-06-14 7:03 ` Arınç ÜNAL
2023-06-14 7:29 ` Vladimir Oltean
2023-06-13 18:20 ` Russell King (Oracle)
2023-06-13 17:52 ` Aw: " Frank Wunderlich
2023-06-11 8:15 ` [PATCH net v2 3/7] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch Arınç ÜNAL
2023-06-11 8:15 ` Arınç ÜNAL [this message]
2023-06-11 8:15 ` [PATCH net v2 5/7] net: dsa: mt7530: fix handling of LLDP frames Arınç ÜNAL
2023-06-11 8:15 ` [PATCH net v2 6/7] net: dsa: introduce preferred_default_local_cpu_port and use on MT7530 Arınç ÜNAL
2023-06-11 8:15 ` [PATCH net v2 7/7] MAINTAINERS: add me as maintainer of MEDIATEK SWITCH DRIVER Arınç ÜNAL
2023-06-11 16:04 ` [PATCH net v2 1/7] net: dsa: mt7530: fix trapping frames with multiple CPU ports on MT7531 Russell King (Oracle)
2023-06-12 6:40 ` Arınç ÜNAL
2023-06-12 10:09 ` Russell King (Oracle)
2023-06-12 10:50 ` Vladimir Oltean
2023-06-13 17:07 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230611081547.26747-4-arinc.unal@arinc9.com \
--to=arinc9.unal@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=bartel.eerdekens@constell8.be \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®